From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhigang Wang Subject: Re: Support upper case identifier in vm.cfg for xl? Date: Mon, 16 Jun 2014 09:17:15 -0400 Message-ID: <539EEE5B.7090302@oracle.com> References: <539B5AE0.6050500@oracle.com> <1402910338.12141.2.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402910338.12141.2.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , xen-devel List-Id: xen-devel@lists.xenproject.org On 06/16/2014 05:18 AM, Ian Campbell wrote: > On Fri, 2014-06-13 at 16:11 -0400, Zhigang Wang wrote: >> Hi, >> >> It seems we only support `[a-z][._0-9a-z]*` as identifiers in vm.cfg for xl >> and upper case letter is not supported. This is different from xm. >> >> An use case is: management tools may put arbitrary key/value pairs into vm.cfg. >> Current xl has limited support of this feature: xl will ignore unknown options. >> >> I wonder whether we can make xl support uppercase letters? > > I think maybe you mean "make the libxlu cfg file parser support > uppercase letters", because you are reusing that library in your > management tool perhaps? Yes. That's what I want. We are planning to use both xl command line and the libxl library. Thanks, Zhigang >> Then management >> tools don't need to change if they already use upper letter identifiers. >> >> Attached patch is a quick fix and seems working for me. Please help to comment on: >> >> 1. Was there a specific reason not to support upper cases? >> (I know it's simple and if there's no xm, this design is the best.) >> >> 2. If we support upper case letters, will it affect other components? >> >> 2. Is this patch correct? >> >> 3. If we want this patch, someone (Ian J.?) also need to generate the in tree >> libxlu_cfg_i.h and libxlu_cfg_l.c. >> >> Thanks, >> >> Zhigang >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel > >