From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbaFPNca (ORCPT ); Mon, 16 Jun 2014 09:32:30 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:36923 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188AbaFPNc2 (ORCPT ); Mon, 16 Jun 2014 09:32:28 -0400 Message-ID: <539EF1E9.8070607@cogentembedded.com> Date: Mon, 16 Jun 2014 17:32:25 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Nick Krause , David Miller CC: andriy.shevchenko@linux.intel.com, dvhart@linux.intel.com, jeffrey.t.kirsher@intel.com, ast@plumgrid.com, dborkman@redhat.com, bhutchings@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb() References: <1402805139-6363-1-git-send-email-xerofoify@gmail.com> <20140614.235300.1228145928404410306.davem@davemloft.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 06/16/2014 12:27 AM, Nick Krause wrote: > From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 > From: Nick > Date: Sun, 15 Jun 2014 16:16:14 -0400 > Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() > Here is the fixed patch changed return type of function to int in > order to use return -ENOMEM as with the function above it , seems to > fit , otherwise returns 0. > Report if it breaks anything related to this driver. > Signed-off-by: Nick You should specify your full name in the "Signed-off:" line. WBR, Sergei