From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] xen/grant-table: fix suspend for non-PV guests Date: Mon, 16 Jun 2014 15:32:40 +0100 Message-ID: <539F0008.9070309@citrix.com> References: <1402919358-9564-1-git-send-email-david.vrabel@citrix.com> <20140616142002.GD11200@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwXxm-0004PG-A7 for xen-devel@lists.xenproject.org; Mon, 16 Jun 2014 14:32:46 +0000 In-Reply-To: <20140616142002.GD11200@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 16/06/14 15:20, Konrad Rzeszutek Wilk wrote: > On Mon, Jun 16, 2014 at 12:49:18PM +0100, David Vrabel wrote: >> Commit aa8532c32216ae07c3813b9aeb774517878a7573 (xen: refactor suspend >> pre/post hooks) broke resuming PVHVM (auto-translated physmap) guests. >> >> The gnttab_suspend() would clear the mapping for the grant table >> frames, but the ->unmap_frames() call is only applicable to PV guests. >> >> Signed-off-by: David Vrabel > > You forgot: > > Reported-by: Konrad Rzeszutek Wilk I'm more interested in a Tested-by, any chance of one? > However, if the code is structured like this, should we just > make the 'unmap_frames' be a NOP for HVM and instead have: > > if (gnttab_interface->unmap_frames) > gnttab_interface->unmap_frames(); > > And the HVM path will make sure that 'unmap_frames' is > set to NULL? > > Maybe even change the name to 'unmap_frames_pv' ? That may be useful as part of a wider refactor. But the use of the feature test mirrors the use in gnttab_setup() (as called by gnttab_resume()) so I think it is clearer. David