From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [RFC PATCH 3/4] Updated comments/variables to
 reflect cbs, fixed formatting and confusing comments/variables
Date: Mon, 16 Jun 2014 16:29:04 +0100
Message-ID: <539F0D40.4000000@eu.citrix.com>
References: <1402689488-3577-1-git-send-email-josh.whitehead@dornerworks.com>
	<1402689488-3577-4-git-send-email-josh.whitehead@dornerworks.com>
	<539ED5F5020000780001A899@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <539ED5F5020000780001A899@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nate Studer <nate.studer@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On 06/16/2014 10:33 AM, Jan Beulich wrote:
>>>> On 13.06.14 at 21:58, <josh.whitehead@dornerworks.com> wrote:
>> --- a/xen/include/public/trace.h
>> +++ b/xen/include/public/trace.h
>> @@ -75,7 +75,7 @@
>>   /* Per-scheduler IDs, to identify scheduler specific events */
>>   #define TRC_SCHED_CSCHED   0
>>   #define TRC_SCHED_CSCHED2  1
>> -#define TRC_SCHED_SEDF     2
>> +#define TRC_SCHED_CBS      2
> While the change to domctl.h is fine, I'm not sure we can allow simple
> renaming elsewhere in the public headers (i.e. the old name may need
> to remain there, guarded with a __XEN_INTERFACE_VERSION__
> conditional).

I think the tracing stuff is fine too -- we've always considered that 
non-stable (and have made incompatible changes across versions).

But the libxl interfaces *do* need to have something sensible done with 
them.

Given that,  I think it would probably be better to make this patch series:

1/N: Add sched_cbs.c to Xen
2/N: Add cbs to toolstack
3/N: Remove sedf scheduler (with appropriate backwards-compatibility bits)

I think that would make it a bit easier to review as well.

  -George