From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v5 21/21] xen/arm: check for GICv3 platform
	support
Date: Mon, 16 Jun 2014 16:37:29 +0100
Message-ID: <539F0F39.2010801@linaro.org>
References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com>	<1402580192-13937-22-git-send-email-vijay.kilari@gmail.com>	<539A2EFE.5010500@linaro.org>
	<CALicx6u206ZgktfJ0BwJcEY3vR5yWnk9Futek_YzuNYphi+JeA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6u206ZgktfJ0BwJcEY3vR5yWnk9Futek_YzuNYphi+JeA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/16/2014 04:28 PM, Vijay Kilari wrote:
> On Fri, Jun 13, 2014 at 4:21 AM, Julien Grall <julien.grall@linaro.org> wrote:
>> On 12/06/14 14:36, vijay.kilari@gmail.com wrote:
>>>
>>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>>
>>> ID_AA64PFR0_EL1 register provides information about GIC support.
>>> Check for this register in GICv3 driver.
>>>
>>> Also print GICv3 support information in boot log
>>
>>
>> We already have a GICv3 node in the device tree. Why do we need to check
>> that GICv3 is effectively support by board?
>>
>> We rely on the user provide us a correct device tree, so I don't think this
>> patch is helpful...
> 
> GICv3 driver is compiled for arm64 alone. Assume that platform does not support
> GICv3 and DT is passed with GICv3 info. In such scenario this patch helps.

I think this is pointless, lots of things (worst than trying to poke a
GICv3 on a GICv2 platform) can happen on Xen and Linux if the user fails
to give a valid device tree.

IHMO, it's safe to assume that the user will provide a device tree with
valid devices...

Regards,

-- 
Julien Grall