Re: [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On 06/05/2014 08:36 AM, Igor Mammedov wrote:
> ... using TYPE_ACPI_DEVICE_IF interface.
> Which provides status reporting of ACPI declared memory devices
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
>  - set slot-type to DIMM
>  - take into account that 'device' field could be optional
> ---
>  hw/acpi/ich9.c                   |    7 +++++++
>  hw/acpi/memory_hotplug.c         |   31 +++++++++++++++++++++++++++++++
>  hw/acpi/piix4.c                  |   11 +++++++++++
>  hw/isa/lpc_ich9.c                |    3 +++
>  include/hw/acpi/ich9.h           |    3 +++
>  include/hw/acpi/memory_hotplug.h |    1 +
>  6 files changed, 56 insertions(+), 0 deletions(-)
> 

> +void acpi_memory_ospm_status(MemHotplugState *mem_st, ACPIOSTInfoList ***list);

Triple indirection looks unusual, but that doesn't make it wrong :)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]