From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipu_disp: squash clang warning
Date: Mon, 16 Jun 2014 12:52:22 -0700 [thread overview]
Message-ID: <539F4AF6.6030704@boundarydevices.com> (raw)
In-Reply-To: <1402947663-20632-1-git-send-email-jeroen@myspectrum.nl>
On 6/16/2014 12:41 PM, Jeroen Hofstee wrote:
> Since &rgb2ycbcr_coeff and friends are declared const, but
> assigned to a void pointer, clang will warn that the const
> is implicity casted away. Add const to indicate the pointer
> points to const data to get rid of these warnings.
>
> Cc: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
> drivers/video/ipu_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
> index cefd2dc..31b5a10 100644
> --- a/drivers/video/ipu_disp.c
> +++ b/drivers/video/ipu_disp.c
> @@ -33,7 +33,7 @@ enum csc_type_t {
>
> struct dp_csc_param_t {
> int mode;
> - void *coeff;
> + void * const coeff;
> };
>
> #define SYNC_WAVE 0
>
Doesn't this says the pointer is constant, not that it points to constant data?
So, commit log needs updated or
const void *coeff;
Troy
next prev parent reply other threads:[~2014-06-16 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:41 [U-Boot] [PATCH] video: ipu_disp: squash clang warning Jeroen Hofstee
2014-06-16 19:52 ` Troy Kisky [this message]
2014-06-16 20:03 ` Jeroen Hofstee
2014-06-16 20:37 ` Jeroen Hofstee
2014-06-16 21:50 ` Troy Kisky
2014-06-17 17:16 ` Jeroen Hofstee
2014-06-17 17:20 ` [U-Boot] [[PATCH v2]] " Jeroen Hofstee
2014-08-11 15:54 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F4AF6.6030704@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.