From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment
Date: Mon, 16 Jun 2014 20:55:47 +0100 [thread overview]
Message-ID: <539F4BC3.3060908@kernel.org> (raw)
In-Reply-To: <1402945277-12721-1-git-send-email-srinivas.pandruvada@linux.intel.com>
On 16/06/14 20:01, Srinivas Pandruvada wrote:
> Need to remove indio_dev->name assignment for id->name as id can
> be NULL. Copy paste bug from ak8975.c where it was fixed later.
>
> kbuild test robot errors:
> error: we previously assumed 'id' could be null (see line 288)
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git as a fixup to the original driver
patch (as that was last in the tree and I hadn't pushed it out properly yet ;)
Thanks,
> ---
> drivers/iio/magnetometer/ak09911.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/ak09911.c b/drivers/iio/magnetometer/ak09911.c
> index 62f980c..b2bc942 100644
> --- a/drivers/iio/magnetometer/ak09911.c
> +++ b/drivers/iio/magnetometer/ak09911.c
> @@ -298,7 +298,6 @@ static int ak09911_probe(struct i2c_client *client,
> indio_dev->channels = ak09911_channels;
> indio_dev->num_channels = ARRAY_SIZE(ak09911_channels);
> indio_dev->info = &ak09911_info;
> - indio_dev->name = id->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->name = name;
>
>
prev parent reply other threads:[~2014-06-16 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:01 [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment Srinivas Pandruvada
2014-06-16 19:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F4BC3.3060908@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.