From: Anish Bhatt <anish@chelsio.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] checkpatch: Warn on unnecessary void function return statements
Date: Mon, 16 Jun 2014 17:44:18 -0700 [thread overview]
Message-ID: <539F8F62.4000805@chelsio.com> (raw)
In-Reply-To: <1402964898.11561.2.camel@joe-AO725>
My code has multiple exit lables:
void function(void)
{
...
if (err1)
goto exit1;
...
if (err2)
goto exit2;
...
return; /* Good return, no errors */
exit1:
printk(err1);
return;
exit2:
printk(err2);
}
The single tabbed return was required to prevent the good return & err1
messages cascading down. The extra exit label with a noop looks weird,
but is passing checkpatch.pl --strict, so I will go with that, thanks.
-Anish
next prev parent reply other threads:[~2014-06-17 0:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 16:58 [PATCH] checkpatch: Warn on unnecessary void function return statements Joe Perches
2014-06-16 23:28 ` Anish Bhatt
2014-06-17 0:28 ` Joe Perches
2014-06-17 0:44 ` Anish Bhatt [this message]
2014-06-17 2:00 ` Joe Perches
2014-06-17 3:16 ` Sachin Kamat
2014-06-17 3:25 ` Joe Perches
2014-06-17 3:35 ` Sachin Kamat
2014-06-17 19:37 ` Anish Bhatt
2014-06-18 17:44 ` [PATCH V2] " Joe Perches
2014-06-18 19:59 ` Anish Bhatt
2014-06-19 20:18 ` Andrew Morton
2014-06-19 20:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F8F62.4000805@chelsio.com \
--to=anish@chelsio.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.