All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Nick <xerofoify@gmail.com>, cody@linux.vnet.ibm.com
Cc: akpm@linux-foundation.org, sjenning@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix comments in rbtree.c
Date: Mon, 16 Jun 2014 20:59:12 -0700	[thread overview]
Message-ID: <539FBD10.6080909@roeck-us.net> (raw)
In-Reply-To: <1402770860-4504-1-git-send-email-xerofoify@gmail.com>

On 06/14/2014 11:34 AM, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
>   lib/rbtree.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/rbtree.c b/lib/rbtree.c
> index 65f4eff..c66370c 100644
> --- a/lib/rbtree.c
> +++ b/lib/rbtree.c
> @@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
>   				 *      / \          / \
>   				 *     p   u  -->   P   U
>   				 *    /            /
> -				 *   n            N
> +				 *   n            n

You'll need a lengthy explanation here. What makes you think that the comment
is wrong ?

Guenter


  reply	other threads:[~2014-06-17  3:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-14 18:34 [PATCH] Fix comments in rbtree.c Nick
2014-06-17  3:59 ` Guenter Roeck [this message]
2014-07-08 16:29   ` Fwd: " Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539FBD10.6080909@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=cody@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjenning@linux.vnet.ibm.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.