From: Sean Cross <xobs@kosagi.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Xiubo Li <Li.Xiubo@freescale.com>,
Nicolin Chen <Guangyu.Chen@freescale.com>
Subject: Re: [PATCH v2 3/3] ASoC: fsl: add imx-es8328 machine driver
Date: Tue, 17 Jun 2014 15:12:14 +0800 [thread overview]
Message-ID: <539FEA4E.503@kosagi.com> (raw)
In-Reply-To: <539FDF92.8070401@metafoo.de>
On 06/17/14 14:26, Lars-Peter Clausen wrote:
> On 06/17/2014 07:16 AM, Sean Cross wrote:
> [...]
>> +- codec-supply : Power regulator for audio codec chip
>
> If this is the supply for the CODEC it should be part of the CODEC's
> bindings and probably be handled by the CODEC driver.
>
>
On this board, it's simply a GPIO on this board that enables or disables
power to the chip. Since it's external to the codec, it seemed more
appropriate to put it in the machine driver file.
Sean
prev parent reply other threads:[~2014-06-17 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 5:16 [PATCH v2 0/3] Add ES8328 audio codec Sean Cross
2014-06-17 5:16 ` [PATCH v2 1/3] devicetree: bindings: Add Everest Semicodunctor Sean Cross
2014-06-17 5:16 ` [PATCH v2 2/3] ASoC: add es8328 codec driver Sean Cross
2014-06-17 6:24 ` Lars-Peter Clausen
2014-06-17 7:10 ` Sean Cross
2014-06-17 5:16 ` [PATCH v2 3/3] ASoC: fsl: add imx-es8328 machine driver Sean Cross
2014-06-17 6:26 ` Lars-Peter Clausen
2014-06-17 7:12 ` Sean Cross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539FEA4E.503@kosagi.com \
--to=xobs@kosagi.com \
--cc=Guangyu.Chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.