From: Andreas Ziegler <br015@umbiko.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/linux-firmware: fix build failure when no firmware item selected
Date: Tue, 09 Mar 2021 18:25:17 +0000 [thread overview]
Message-ID: <539abc1b8ea48daa694b45242cab63d0@umbiko.net> (raw)
The latest change in Linux firmware handling breaks the build if no
specific firmware item is selected below BR2_PACKAGE_LINUX_FIRMWARE.
The firmware archive is only created if at least one firmware
sub-category is selected; the installation step wants to unpack the
archive unconditionally.
Use the same condition to control install command definition as in the
build step.
Signed-off-by: Andreas Ziegler <br015@umbiko.net>
diff --git a/package/linux-firmware/linux-firmware.mk
b/package/linux-firmware/linux-firmware.mk
index 5e92b0446e..5dfc4a657d 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -675,6 +675,7 @@ endif
# sure we canonicalize the pointed-to file, to cover the symlinks of
the form
# a/foo -> ../b/foo where a/ (the directory where to put the symlink)
does
# not yet exist.
+ifneq ($(LINUX_FIRMWARE_FILES)$(LINUX_FIRMWARE_DIRS),)
define LINUX_FIRMWARE_INSTALL_FW
mkdir -p $(1)
$(TAR) xf $(@D)/br-firmware.tar -C $(1)
@@ -695,5 +696,6 @@ endef
define LINUX_FIRMWARE_INSTALL_IMAGES_CMDS
$(call LINUX_FIRMWARE_INSTALL_FW, $(BINARIES_DIR))
endef
+endif # LINUX_FIRMWARE_FILES || LINUX_FIRMWARE_DIRS
$(eval $(generic-package))
next reply other threads:[~2021-03-09 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 18:25 Andreas Ziegler [this message]
2021-03-09 20:07 ` [Buildroot] [PATCH 1/1] package/linux-firmware: fix build failure when no firmware item selected Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539abc1b8ea48daa694b45242cab63d0@umbiko.net \
--to=br015@umbiko.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.