From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwqyc-00062L-5k for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwqyO-00040C-Iv for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:50:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56660 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwqyO-000400-Bq for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:50:40 -0400 Message-ID: <53A01D7E.9050608@suse.de> Date: Tue, 17 Jun 2014 12:50:38 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1402939751-8371-1-git-send-email-somlo@cmu.edu> <539F7126.6070205@suse.de> <539FC485.7070305@redhat.com> <56911E93-9334-42E7-A631-74B7A09CE454@suse.de> <20140617104801.GA6991@redhat.com> In-Reply-To: <20140617104801.GA6991@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: "romain@dolbeau.org" , "qemu-devel@nongnu.org" , "Gabriel L. Somlo" , "stefanha@redhat.com" , Paolo Bonzini , "afaerber@suse.de" On 17.06.14 12:48, Michael S. Tsirkin wrote: > On Tue, Jun 17, 2014 at 08:33:00AM +0200, Alexander Graf wrote: >> >>> Am 17.06.2014 um 06:31 schrieb Paolo Bonzini : >>> >>> Il 17/06/2014 00:35, Alexander Graf ha scritto: >>>>> On 16.06.14 19:29, Gabriel L. Somlo wrote: >>>>> This series contains a few fixes and improvements in the emulation >>>>> of link auto-negotiation: >>>>> >>>>> - use auto-negotiation when the link is bounced externally (e.g. via >>>>> set_link down/up on the qemu monitor command line). >>>>> >>>>> - allow mii_tool on linux access to all the phy registers and flags >>>>> it requires in order to report a successfully auto-negotiated link. >>>>> >>>>> - inject LSC interrupt upon successful link auto-negotiation (required >>>>> by stock OS X e1000 driver). >>>>> >>>>> See additional prose following commit logs in 2/3 (making up excuses >>>>> for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows >>>>> re. auto-negotiation and LSC injection). >>>> Looks very reasonable and straight forward to me. >>>> >>>> Reviewed-by: Alexander Graf >>> Would you pick it up and send a pull request for it? >> Is e1000 / networking unmaintained? >> >> Alex > It isn't - both me and Stefan merge patches there. > It hasn't been a full day since patch was posted, > and I was unwell yesterday. > Why the query? Is there any urgency? No urgency at all, probably just a misunderstanding on Paolos side that I'm reviewing non-PPC patches for a change ;). Alex