Re: [Qemu-devel] [PATCH v5 00/10] Modify block jobs to use node-names

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

On 06/13/2014 12:52 PM, Jeff Cody wrote:
> Changes from v4->v5:
> 
> * Rebased on master
> * Fixed commit log typos / stale paragraphs (Eric)
> * Fixed comment typo (Eric)
> * Added Eric's remaining R-b's
> 

On IRC, we found another bug that needs repairing:

# cd /tmp
# echo tmp > tmp
# qemu-kvm -qmp stdio -drive file=/tmp/tmp
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 2},
"package": ""}, "capabilities": []}}
{"execute":"qmp_capabilities"}
{"return": {}}
{"execute":"block-commit","arguments":{"device":"ide0-hd0"}}
{"return": {}}
{"timestamp": {"seconds": 1402972048, "microseconds": 153175}, "event":
"BLOCK_JOB_READY", "data": {"device": "ide0-hd0", "len": 512, "offset":
512, "speed": 0, "type": "commit"}}
{"execute":"block-job-complete","arguments":{"device":"ide0-hd0"}}
{"return": {}}
qemu-system-x86_64: block.c:2034: bdrv_swap: Assertion
`bs_new->device_name[0] == '\0'' failed.
Aborted (core dumped)

Attempts to commit-to-self should be rejected at block-commit time,
rather than causing an assertion failure down the road.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]