From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Tue, 17 Jun 2014 14:22:34 +0000 Subject: Re: [lm-sensors] [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor Message-Id: <53A04F2A.80104@roeck-us.net> List-Id: References: <1402992713-22711-1-git-send-email-hs@denx.de> <53A01CE6.4010608@roeck-us.net> <53A02013.1060403@denx.de> In-Reply-To: <53A02013.1060403@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hs@denx.de Cc: lm-sensors@lm-sensors.org, Jean Delvare , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org On 06/17/2014 04:01 AM, Heiko Schocher wrote: > Hello Guenter > > Am 17.06.2014 12:48, schrieb Guenter Roeck: >> On 06/17/2014 01:11 AM, Heiko Schocher wrote: >>> Driver for the TI TMP103. >>> >>> The TI TMP103 is similar to the TMP102. It differs from the TMP102 >>> by having only 8 bit registers. >>> >>> Signed-off-by: Heiko Schocher >>> >> [ ... ] >>> +#define TMP103_CONF_SD (TMP103_CONF_M0 | TMP103_CONF_M1) >> >> Hello Heiko, >> >> I thought this needs to be TMP103_CONF_M1, but from the datasheet it looks >> like it does not matter if M0 is set if M1 is set as well. Did you test it, >> though, to make sure that it works ? I feel slightly uncomfortable with it. > > Yes, i tested it on an imx6 based board. I see no issues ... but I can > test it with "#define TMP103_CONF_SD TMP103_CONF_M1" and post a v5 with > this setting if it works ... > Hello Heiko, I would appreciate that. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor Date: Tue, 17 Jun 2014 07:22:34 -0700 Message-ID: <53A04F2A.80104@roeck-us.net> References: <1402992713-22711-1-git-send-email-hs@denx.de> <53A01CE6.4010608@roeck-us.net> <53A02013.1060403@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53A02013.1060403@denx.de> Sender: linux-doc-owner@vger.kernel.org To: hs@denx.de Cc: lm-sensors@lm-sensors.org, Jean Delvare , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org List-Id: devicetree@vger.kernel.org On 06/17/2014 04:01 AM, Heiko Schocher wrote: > Hello Guenter > > Am 17.06.2014 12:48, schrieb Guenter Roeck: >> On 06/17/2014 01:11 AM, Heiko Schocher wrote: >>> Driver for the TI TMP103. >>> >>> The TI TMP103 is similar to the TMP102. It differs from the TMP102 >>> by having only 8 bit registers. >>> >>> Signed-off-by: Heiko Schocher >>> >> [ ... ] >>> +#define TMP103_CONF_SD (TMP103_CONF_M0 | TMP103_CONF_M1) >> >> Hello Heiko, >> >> I thought this needs to be TMP103_CONF_M1, but from the datasheet it looks >> like it does not matter if M0 is set if M1 is set as well. Did you test it, >> though, to make sure that it works ? I feel slightly uncomfortable with it. > > Yes, i tested it on an imx6 based board. I see no issues ... but I can > test it with "#define TMP103_CONF_SD TMP103_CONF_M1" and post a v5 with > this setting if it works ... > Hello Heiko, I would appreciate that. Thanks, Guenter