From: Jeff Liu <jeff.liu@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 20/24] ext4: return actual error on ext4_init_fs
Date: Tue, 17 Jun 2014 22:32:54 +0800 [thread overview]
Message-ID: <53A05196.60801@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Return the actual error code if call kset_create_and_add() failed
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/ext4/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index b9b9aab..5912193 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5545,8 +5545,8 @@ static int __init ext4_init_fs(void)
if (err)
goto out6;
ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj);
- if (!ext4_kset) {
- err = -ENOMEM;
+ if (IS_ERR(ext4_kset)) {
+ err = PTR_ERR(ext4_kset);
goto out5;
}
ext4_proc_root = proc_mkdir("fs/ext4", NULL);
--
1.8.3.2
next reply other threads:[~2014-06-17 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:32 Jeff Liu [this message]
2014-06-17 15:13 ` [PATCH 20/24] ext4: return actual error on ext4_init_fs Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A05196.60801@oracle.com \
--to=jeff.liu@oracle.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.