From: Jeff Liu <jeff.liu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 22/24] ocfs2: return actual error on sysfs functions
Date: Tue, 17 Jun 2014 22:34:40 +0800 [thread overview]
Message-ID: <53A05200.9070805@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Return the actual error code if kset_create_and_add() failed
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/ocfs2/cluster/sys.c | 4 ++--
fs/ocfs2/stackglue.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/cluster/sys.c b/fs/ocfs2/cluster/sys.c
index b7f5727..6d8c793 100644
--- a/fs/ocfs2/cluster/sys.c
+++ b/fs/ocfs2/cluster/sys.c
@@ -65,8 +65,8 @@ int o2cb_sys_init(void)
int ret;
o2cb_kset = kset_create_and_add("o2cb", NULL, fs_kobj);
- if (!o2cb_kset)
- return -ENOMEM;
+ if (IS_ERR(o2cb_kset))
+ return PTR_ERR(o2cb_kset);
ret = sysfs_create_group(&o2cb_kset->kobj, &o2cb_attr_group);
if (ret)
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index 5d965e8..e6eae89 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -641,8 +641,8 @@ static int ocfs2_sysfs_init(void)
int ret;
ocfs2_kset = kset_create_and_add("ocfs2", NULL, fs_kobj);
- if (!ocfs2_kset)
- return -ENOMEM;
+ if (IS_ERR(ocfs2_kset))
+ return PTR_ERR(ocfs2_kset);
ret = sysfs_create_group(&ocfs2_kset->kobj, &ocfs2_attr_group);
if (ret)
--
1.8.3.2
next reply other threads:[~2014-06-17 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:34 Jeff Liu [this message]
2014-06-18 1:51 ` [Ocfs2-devel] [PATCH 22/24] ocfs2: return actual error on sysfs functions Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A05200.9070805@oracle.com \
--to=jeff.liu@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.