All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: JBottomley@parallels.com, gregkh@linuxfoundation.org
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH 11/24] drviers/scsi: check sysfs init return value via IS_ERR at iscsi_boot_create_kset
Date: Tue, 17 Jun 2014 22:34:50 +0800	[thread overview]
Message-ID: <53A0520A.8050509@oracle.com> (raw)

From: Jie Liu <jeff.liu@oracle.com>

kset_create_and_add() has been fixed to return the actual error ptr
than NULL on failure, update iscsi_boot_create_kset() to check the
return value via IS_ERR() accordingly.

Cc: James E.J. Bottomley <JBottomley@parallels.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 drivers/scsi/iscsi_boot_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
index 680bf6f..821df62 100644
--- a/drivers/scsi/iscsi_boot_sysfs.c
+++ b/drivers/scsi/iscsi_boot_sysfs.c
@@ -443,7 +443,7 @@ struct iscsi_boot_kset *iscsi_boot_create_kset(const char *set_name)
 		return NULL;
 
 	boot_kset->kset = kset_create_and_add(set_name, NULL, firmware_kobj);
-	if (!boot_kset->kset) {
+	if (IS_ERR(boot_kset->kset)) {
 		kfree(boot_kset);
 		return NULL;
 	}
-- 
1.8.3.2

             reply	other threads:[~2014-06-17 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 14:34 Jeff Liu [this message]
2014-06-17 19:22 ` [PATCH 11/24] drviers/scsi: check sysfs init return value via IS_ERR at iscsi_boot_create_kset Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A0520A.8050509@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=JBottomley@parallels.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.