Re: [PATCH v3] IOMMU: Prevent VT-d device IOTLB operations on wrong IOMMU

[Malcolm Crossley <malcolm.crossley@citrix.com>]

On 17/06/14 16:06, Jan Beulich wrote:
>>>> On 17.06.14 at 16:37, <malcolm.crossley@citrix.com> wrote:
>> --- a/xen/drivers/passthrough/vtd/x86/ats.c
>> +++ b/xen/drivers/passthrough/vtd/x86/ats.c
>> @@ -120,6 +120,10 @@ int dev_invalidate_iotlb(struct iommu *i
>>      {
>>          sid = (pdev->bus << 8) | pdev->devfn;
>>  
>> +        /* Only invalidate devices that belong to this IOMMU */
>> +        if ( !pdev->iommu || pdev->iommu != iommu )
>> +            continue;
> 
> I meant to ask before and then forgot: What is the first half of this
> condition good/needed for?
>
Defensive coding to prevent a NULL pointer deference if the Intel or
core ATS code goes wrong.

Malcolm

> Jan
>