Re: [Qemu-devel] [PATCH v2] add input-send-event command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On 06/17/2014 10:22 AM, Marcelo Tosatti wrote:
> 
> Which allows specification of absolute/relative,
> up/down and console parameters.
> 
> Suggested by Gerd Hoffman.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> ---
>  qapi-schema.json |   18 +++++++++++++++
>  qmp-commands.hx  |   63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ui/input.c       |   31 +++++++++++++++++++++++++++
>  3 files changed, 112 insertions(+)

> +
> +Example (1):
> +
> +Press left mouse button.

Maybe:

Press, then later release, left mouse button.

> +
> +-> { "execute": "input-send-event",
> +    "arguments": { "console": 0,
> +                   "events": [ { "type": "btn",
> +                    "data" : { "down": true, "button": "Left" } } } }
> +<- { "return": {} }
> +
> +-> { "execute": "input-send-event",
> +    "arguments": { "console": 0,
> +                   "events": [ { "type": "btn",
> +                    "data" : { "down": false, "button": "Left" } } } }
> +<- { "return": {} }

to make it clear that both command/response sequences are part of the
same example.

but that's cosmetic, so whether or not you change it, I can live with:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]