From: Paolo Bonzini <pbonzini@redhat.com>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@gmail.com, arei.gonglei@huawei.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd()
Date: Tue, 17 Jun 2014 19:37:06 +0200 [thread overview]
Message-ID: <53A07CC2.3030401@redhat.com> (raw)
In-Reply-To: <1402065233-31894-3-git-send-email-akong@redhat.com>
Il 06/06/2014 16:33, Amos Kong ha scritto:
> + va_end(ap);
> +
> + escaped_cmd = g_strescape(cmd, NULL);
> + response = qmp("{\"execute\": \"human-monitor-command\","
> + " \"arguments\": {"
> + " \"command-line\": \"%s\""
> + "}}", escaped_cmd);
> + g_free(escaped_cmd);
Instead of adding g_strescape everywhere, we should use json-parser's
own interpolation support. See this patch:
http://article.gmane.org/gmane.comp.emulators.qemu/279836 which also
fixes a leak as a bonus.
Also, you can use ' instead of " if you fix another long-standing bug:
http://article.gmane.org/gmane.comp.emulators.qemu/279835
Paolo
next prev parent reply other threads:[~2014-06-17 17:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:33 [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug Amos Kong
2014-06-06 14:33 ` [Qemu-devel] [PATCH v4 1/4] virtio-blk-test.c: change pci_nop() to virtblk_init() Amos Kong
2014-06-06 14:33 ` [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd() Amos Kong
2014-06-17 13:16 ` Andreas Färber
2014-06-17 17:37 ` Paolo Bonzini [this message]
2014-06-18 6:29 ` Amos Kong
2014-06-18 7:05 ` Paolo Bonzini
2014-06-06 14:33 ` [Qemu-devel] [PATCH v4 3/4] virtio-blk-test.c: add hotplug subtest Amos Kong
2014-06-17 13:25 ` Andreas Färber
2014-06-18 6:40 ` Amos Kong
2014-06-18 10:26 ` Andreas Färber
2014-06-06 14:33 ` [Qemu-devel] [PATCH v4 4/4] qtest: use qmp_exec_hmp_cmd() in blockdev-test Amos Kong
2014-06-17 13:28 ` Andreas Färber
2014-06-09 13:22 ` [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug Stefan Hajnoczi
2014-06-17 12:54 ` Amos Kong
2014-06-17 13:37 ` Andreas Färber
2014-06-18 2:58 ` Amos Kong
2014-06-18 3:04 ` Stefan Hajnoczi
2014-06-18 5:46 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A07CC2.3030401@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.