From: Steve Dickson <SteveD@redhat.com>
To: Ditang Chen <chendt.fnst@cn.fujitsu.com>
Cc: Trond Myklebust <trond.myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"yaoxp@cn.fujitsu.com" <yaoxp@cn.fujitsu.com>
Subject: Re: [PATCH]statd: create statdpath dir if specify the "--with-statdpath=xx" parameter in configure nfs-utils source code
Date: Tue, 17 Jun 2014 14:06:28 -0400 [thread overview]
Message-ID: <53A083A4.4020304@RedHat.com> (raw)
In-Reply-To: <539132AF.8060805@cn.fujitsu.com>
On 06/05/2014 11:17 PM, Ditang Chen wrote:
> When configure the nfs-utils source code with "--with-statdpath=/foo" parameter，
> #define NSM_DEFAULT_STATEDIR "/foo" will be generated in support/include/config.h file,
> but Makefile will not create "/foo" dir.
>
> Signed-off-by: chendt.fnst@cn.fujitsu.com
> Reported-by: yaoxp@cn.fujitsu.com
> ---
> Makefile.am | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Committed....
steved
>
> diff --git a/Makefile.am b/Makefile.am
> index ae7cd16..5824adc 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -54,13 +54,13 @@ install-data-hook:
> touch $(DESTDIR)$(statedir)/xtab; chmod 644 $(DESTDIR)$(statedir)/xtab
> touch $(DESTDIR)$(statedir)/etab; chmod 644 $(DESTDIR)$(statedir)/etab
> touch $(DESTDIR)$(statedir)/rmtab; chmod 644 $(DESTDIR)$(statedir)/rmtab
> - mkdir -p $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak
> - touch $(DESTDIR)$(statedir)/state
> - chmod go-rwx $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state
> - -chown $(statduser) $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state
> + mkdir -p $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak
> + touch $(DESTDIR)$(statdpath)/state
> + chmod go-rwx $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statdpath)/state
> + -chown $(statduser) $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statdpath)/state
>
> uninstall-hook:
> rm $(DESTDIR)$(statedir)/xtab
> rm $(DESTDIR)$(statedir)/etab
> rm $(DESTDIR)$(statedir)/rmtab
> - rm $(DESTDIR)$(statedir)/state
> + rm $(DESTDIR)$(statdpath)/state
>
prev parent reply other threads:[~2014-06-17 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:14 [PATCH]statd: create statdpath dir if specify the "--with-statdpath=xx" parameter in configure nfs-utils source code Ditang Chen
2014-06-05 12:38 ` Trond Myklebust
2014-06-05 14:15 ` Steve Dickson
2014-06-05 14:20 ` Trond Myklebust
2014-06-06 3:09 ` Ditang Chen
2014-06-06 3:17 ` Ditang Chen
2014-06-17 18:06 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A083A4.4020304@RedHat.com \
--to=steved@redhat.com \
--cc=chendt.fnst@cn.fujitsu.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
--cc=yaoxp@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.