From: Eric Blake <eblake@redhat.com>
To: Chunyan Liu <cyliu@suse.com>, stefanha@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] check NULL opts in qemu_opt_get functions
Date: Tue, 17 Jun 2014 22:04:00 -0600 [thread overview]
Message-ID: <53A10FB0.3050903@redhat.com> (raw)
In-Reply-To: <1403059646-4161-1-git-send-email-cyliu@suse.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On 06/17/2014 08:47 PM, Chunyan Liu wrote:
> Some places will call bdrv_create_file(filename, NULL, &local_err), where
> opts is NULL. Check NULL in qemu_opt_get and qemu_opt_get_*_del functions,
> to avoid extra effort of checking opts before calling them every time.
>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
> Fix reported bugs:
> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03866.html
>
> ---
> util/qemu-option.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-18 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 2:47 [Qemu-devel] [PATCH] check NULL opts in qemu_opt_get functions Chunyan Liu
2014-06-18 4:04 ` Eric Blake [this message]
2014-06-19 3:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A10FB0.3050903@redhat.com \
--to=eblake@redhat.com \
--cc=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.