From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wx7Xb-0002Ya-93
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:32:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wx7XT-0001lu-Pz
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:32:07 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:43626)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wx7XT-0001lR-JA
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:31:59 -0400
Message-ID: <53A1163A.1060902@weilnetz.de>
Date: Wed, 18 Jun 2014 06:31:54 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1403039230-3427-1-git-send-email-sw@weilnetz.de>
	<53A1157E.9020409@twiddle.net>
In-Reply-To: <53A1157E.9020409@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libvixl: Add gcc format attribute
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>

Am 18.06.2014 06:28, schrieb Richard Henderson:
>> I don't know the reason, because all locations seem to have arguments
>> which are function calls, and the called function returns Instr which
>> is uint32_t, not int64_t.
> ...
>> +  void GCC_FMT_ATTR(2, 3) AppendToOutput(const char* string, ...);
> 
> It "helps" because 2,3 is wrong.  Correct would be 1,2 for this function.
> 
> 
> r~
> 

No. This is a class member function, so there is an invisible fist
"this" argument which counts for the gcc format attribute.

gcc would complain if the numbering were wrong.

Stefan