All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Merla, ShivaKrishna" <ShivaKrishna.Merla@netapp.com>,
	"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH ] multipath: Fall back to getuid_callout if ID_SERIAL attribute is missing.
Date: Wed, 18 Jun 2014 08:18:00 +0200	[thread overview]
Message-ID: <53A12F18.60300@suse.de> (raw)
In-Reply-To: <229730203dc540ef9cae7b665577519c@hioexcmbx01-prd.hq.netapp.com>

On 06/18/2014 02:17 AM, Merla, ShivaKrishna wrote:
>   Sometimes whenever a path is added, scsi_id call during udev rule processing
>   can fail and ID_SERIAL attribute will not be set. This causes multipathd to add
>   the path as orphan. We have seen several instances of this happening during
>   testing.
>
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: uid_attribute = ID_SERIAL (config file default)
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: no ID_SERIAL attribute
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: uid = <empty> (udev)
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: no ID_SERIAL attribute
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: uid = <empty> (udev)
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: failed to get path uid
>        Jun 17 10:14:43 ictm-vader multipathd[474]: sda: orphan path, failed to add path
>
>   This patch handles this case by allowing to fall back to explict getuid_callout
>   incase if ID_SERIAL attribute is not set. This way support for deprecated
>   getuid_callout is not lost for older versions where ID_SERIAL attribute is not
>   present but also serves good purpose in the scenario mentioned above.
>
> Signed-off-by: Shiva Krishna Merla<shivakrishna.merla@netapp.com>

Hmm. I have a similar patch in my tree. Will be checking.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

  reply	other threads:[~2014-06-18  6:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  0:17 [PATCH ] multipath: Fall back to getuid_callout if ID_SERIAL attribute is missing Merla, ShivaKrishna
2014-06-18  6:18 ` Hannes Reinecke [this message]
2014-07-16 15:41   ` Merla, ShivaKrishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A12F18.60300@suse.de \
    --to=hare@suse.de \
    --cc=ShivaKrishna.Merla@netapp.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.