From: Roger Quadros <rogerq@ti.com>
To: mturquette@linaro.org, tony@atomide.com
Cc: t-kristo@ti.com, nm@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] clk: ti: am43x: Fix boot with CONFIG_SOC_AM33XX disabled
Date: Wed, 18 Jun 2014 10:52:05 +0300 [thread overview]
Message-ID: <53A14525.5050208@ti.com> (raw)
In-Reply-To: <1403013804-13522-1-git-send-email-rogerq@ti.com>
On 06/17/2014 05:03 PM, Roger Quadros wrote:
> Define ti_clk_register_dpll_x2() and of_ti_am3_dpll_x2_setup() if
> AM43XX is defined.
>
> Fixes the below boot issue.
>
> [ 2.157258] gpmc_l3_clk not enabled
> [ 2.161194] gpmc_l3_clk not enabled
> [ 2.164896] Division by zero in kernel.
> [ 2.169055] CPU: 0 PID: 321 Comm: kworker/u2:2 Tainted: G W 3.16.0-rc1-00008-g4c0e520 #273
> [ 2.178880] Workqueue: deferwq deferred_probe_work_func
> [ 2.184459] [<c001477c>] (unwind_backtrace) from [<c001187c>] (show_stack+0x10/0x14)
> [ 2.192752] [<c001187c>] (show_stack) from [<c0530f28>] (dump_stack+0x80/0x9c)
> [ 2.200486] [<c0530f28>] (dump_stack) from [<c02c867c>] (Ldiv0+0x8/0x10)
> [ 2.207678] [<c02c867c>] (Ldiv0) from [<c0022da0>] (gpmc_calc_divider+0x24/0x40)
> [ 2.215490] [<c0022da0>] (gpmc_calc_divider) from [<c0022e20>] (gpmc_cs_set_timings+0x18/0x474)
> [ 2.224783] [<c0022e20>] (gpmc_cs_set_timings) from [<c003069c>] (gpmc_nand_init+0x74/0x1a8)
> [ 2.233791] [<c003069c>] (gpmc_nand_init) from [<c0024668>] (gpmc_probe+0x52c/0x874)
> [ 2.242089] [<c0024668>] (gpmc_probe) from [<c0349218>] (platform_drv_probe+0x18/0x48)
> [ 2.250534] [<c0349218>] (platform_drv_probe) from [<c0347d88>] (driver_probe_device+0x104/0x22c)
> [ 2.259988] [<c0347d88>] (driver_probe_device) from [<c03464dc>] (bus_for_each_drv+0x44/0x8c)
> [ 2.269087] [<c03464dc>] (bus_for_each_drv) from [<c0347c4c>] (device_attach+0x74/0x8c)
> [ 2.277620] [<c0347c4c>] (device_attach) from [<c0347380>] (bus_probe_device+0x88/0xb0)
> [ 2.286074] [<c0347380>] (bus_probe_device) from [<c0347768>] (deferred_probe_work_func+0x60/0x90)
> [ 2.295611] [<c0347768>] (deferred_probe_work_func) from [<c004ef50>] (process_one_work+0x1b4/0x4bc)
> [ 2.305288] [<c004ef50>] (process_one_work) from [<c004f3d4>] (worker_thread+0x148/0x550)
> [ 2.313954] [<c004f3d4>] (worker_thread) from [<c0055a48>] (kthread+0xc8/0xe4)
> [ 2.321628] [<c0055a48>] (kthread) from [<c000e648>] (ret_from_fork+0x14/0x2c)
>
Sorry to miss that this was reported by Tony.
Reported-by: Tony Lindgren <tony@atomide.com>
cheers,
-roger
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/clk/ti/dpll.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c
> index abd956d..79791e1 100644
> --- a/drivers/clk/ti/dpll.c
> +++ b/drivers/clk/ti/dpll.c
> @@ -161,7 +161,8 @@ cleanup:
> }
>
> #if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || \
> - defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM33XX)
> + defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM33XX) || \
> + defined(CONFIG_SOC_AM43XX)
> /**
> * ti_clk_register_dpll_x2 - Registers a DPLLx2 clock
> * @node: device node for this clock
> @@ -322,7 +323,7 @@ CLK_OF_DECLARE(ti_omap4_dpll_x2_clock, "ti,omap4-dpll-x2-clock",
> of_ti_omap4_dpll_x2_setup);
> #endif
>
> -#ifdef CONFIG_SOC_AM33XX
> +#if defined(CONFIG_SOC_AM33XX) || defined(CONFIG_SOC_AM43XX)
> static void __init of_ti_am3_dpll_x2_setup(struct device_node *node)
> {
> ti_clk_register_dpll_x2(node, &dpll_x2_ck_ops, NULL);
>
next prev parent reply other threads:[~2014-06-18 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:03 [PATCH] clk: ti: am43x: Fix boot with CONFIG_SOC_AM33XX disabled Roger Quadros
2014-06-18 7:52 ` Roger Quadros [this message]
2014-06-19 11:33 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A14525.5050208@ti.com \
--to=rogerq@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.