All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: Josef Bacik <jbacik@fb.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] xfstests/btrfs: add qgroup rescan stress test
Date: Wed, 18 Jun 2014 16:36:22 +0800	[thread overview]
Message-ID: <53A14F86.9000506@cn.fujitsu.com> (raw)
In-Reply-To: <1399615343-28544-1-git-send-email-wangsl.fnst@cn.fujitsu.com>

Hello Josef,

The lastest Qgroup code still break this test sometimes.

Ps: this test seems not merging into xfstests.

On 05/09/2014 02:02 PM, Wang Shilong wrote:
> Test flow is to run fsstress after triggering quota rescan.
> the ruler is simple, we just remove all files and directories,
> sync filesystem and see if qgroup's ref and excl are nodesize.
>
> Signed-off-by: Wang Shilong<wangsl.fnst@cn.fujitsu.com>
> ---
> v2->v3: addressed comments from josef:
> 	- remove unnecessary redirections
> 	- don't use _run_btrfs_util_prog() when capturing qgroup show output.
> 	- turn off inode_cache mount option explicitly.
>
> v1->v2: switch to _run_btrfs_util_prog()
> ---
>   tests/btrfs/050     | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   tests/btrfs/050.out |  3 ++
>   tests/btrfs/group   |  1 +
>   3 files changed, 85 insertions(+)
>   create mode 100644 tests/btrfs/050
>   create mode 100644 tests/btrfs/050.out
>
> diff --git a/tests/btrfs/050 b/tests/btrfs/050
> new file mode 100644
> index 0000000..81d953a
> --- /dev/null
> +++ b/tests/btrfs/050
> @@ -0,0 +1,81 @@
> +#! /bin/bash
> +# FSQA Test No. btrfs/050
> +#
> +# Quota rescan stress test, we run fsstress and quota rescan concurrently
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (C) 2014 Fujitsu.  All rights reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1
> +
> +_cleanup()
> +{
> +	cd /
> +	rm -f $tmp.*
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_need_to_be_root
> +_supported_fs btrfs
> +_supported_os Linux
> +_require_scratch
> +
> +rm -f $seqres.full
> +
> +# use small leaf size to get higher btree height.
> +run_check _scratch_mkfs "-b 1g --nodesize 4096"
> +
> +# inode cache is saved in the FS tree itself for every
> +# individual FS tree,that affects the sizes reported by qgroup show
> +# so we need to explicitly turn it off to get consistent values.
> +run_check _scratch_mount "-o noinode_cache"
> +
> +# -w ensures that the only ops are ones which cause write I/O
> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT -w -p 5 -n 1000 \
> +		$FSSTRESS_AVOID >&/dev/null
> +
> +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT \
> +	$SCRATCH_MNT/snap1
> +
> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT/snap1 -w -p 5 -n 1000 \
> +       $FSSTRESS_AVOID >&/dev/null
> +
> +_run_btrfs_util_prog quota enable $SCRATCH_MNT
> +_run_btrfs_util_prog quota rescan -w $SCRATCH_MNT
> +
> +# ignore removing subvolume errors
> +rm -rf $SCRATCH_MNT/* >& /dev/null
> +
> +_run_btrfs_util_prog filesystem sync $SCRATCH_MNT
> +$BTRFS_UTIL_PROG qgroup show $SCRATCH_MNT | $SED_PROG -n '/[0-9]/p' \
> +	| $AWK_PROG '{print $2" "$3}'
> +
> +status=0
> +exit
> diff --git a/tests/btrfs/050.out b/tests/btrfs/050.out
> new file mode 100644
> index 0000000..a388160
> --- /dev/null
> +++ b/tests/btrfs/050.out
> @@ -0,0 +1,3 @@
> +QA output created by 050
> +4096 4096
> +4096 4096
> diff --git a/tests/btrfs/group b/tests/btrfs/group
> index 59b0c98..ee3e8a5 100644
> --- a/tests/btrfs/group
> +++ b/tests/btrfs/group
> @@ -52,3 +52,4 @@
>   047 auto quick
>   048 auto quick
>   049 auto quick
> +050 auto quick


  parent reply	other threads:[~2014-06-18  8:40 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  3:44 [PATCH v2 1/3] xfstests/btrfs: add qgroup rescan stress test Wang Shilong
2014-03-10  3:44 ` Wang Shilong
2014-03-10  3:44 ` [PATCH v2 2/3] xfstests/btrfs: add basic functional test for btrfs quota groups Wang Shilong
2014-03-10  3:44   ` Wang Shilong
2014-03-10 19:46   ` Josef Bacik
2014-03-10 19:46     ` Josef Bacik
2014-03-10  3:44 ` [PATCH v2 3/3] xfstests/btrfs: add stress test for btrfs quota operations Wang Shilong
2014-03-10  3:44   ` Wang Shilong
2014-03-10 19:48   ` Josef Bacik
2014-03-10 19:48     ` Josef Bacik
2014-03-13  3:12     ` Dave Chinner
2014-03-13  3:12       ` Dave Chinner
2014-03-13 14:02       ` Josef Bacik
2014-03-13 14:02         ` Josef Bacik
2014-03-10 19:43 ` [PATCH v2 1/3] xfstests/btrfs: add qgroup rescan stress test Josef Bacik
2014-03-10 19:43   ` Josef Bacik
2014-03-11  1:19   ` Wang Shilong
2014-03-11  1:19     ` Wang Shilong
2014-05-07 20:58 ` Josef Bacik
2014-05-07 20:58   ` Josef Bacik
2014-05-08  3:38   ` Wang Shilong
2014-05-08  3:38     ` Wang Shilong
2014-05-08 18:33     ` Josef Bacik
2014-05-08 18:33       ` Josef Bacik
2014-05-09  1:17       ` Wang Shilong
2014-05-09  1:17         ` Wang Shilong
2014-05-09  2:13         ` Josef Bacik
2014-05-09  2:13           ` Josef Bacik
2014-05-09  2:43           ` Wang Shilong
2014-05-09  2:43             ` Wang Shilong
2014-05-09 17:24             ` Josef Bacik
2014-05-09 17:24               ` Josef Bacik
2014-05-09  6:02 ` [PATCH v3] " Wang Shilong
2014-05-09  6:02   ` Wang Shilong
2014-05-09 17:32   ` Josef Bacik
2014-05-09 17:32     ` Josef Bacik
2014-06-18  8:36   ` Wang Shilong [this message]
2014-06-18 15:24     ` Josef Bacik
2014-06-19  0:51     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A14F86.9000506@cn.fujitsu.com \
    --to=wangsl.fnst@cn.fujitsu.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.