From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 16/21] xen/arm: split vgic driver into generic and vgic-v2 driver Date: Wed, 18 Jun 2014 10:17:27 +0100 Message-ID: <53A15927.7070201@linaro.org> References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com> <1402580192-13937-17-git-send-email-vijay.kilari@gmail.com> <1403011284.16844.101.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari , Ian Campbell Cc: Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 18/06/14 04:33, Vijay Kilari wrote: > On Tue, Jun 17, 2014 at 6:51 PM, Ian Campbell wrote: >> On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@gmail.com wrote: >>> +extern int vgic_to_sgi(struct vcpu *v, register_t sgir, >>> + enum gic_sgi_mode irqmode, int virq, >>> + unsigned long vcpu_mask); >> >> No externs in C files please. Put them in the appropriate header. > > OK. I remember why I placed this here. > The enum gic_sig_mode is defined in gic.h and used by both gic and vgic > C files. So this function declaration in vgic.h requires gic.h and > gic.h requires vgic.h. > So there is cross dependency between vgic.h and gic.h file > > Solution is to move enum gic_sgi_mode to vgic.h which I will take care enum gic_sgi_mode belongs to gic.h not vgic.h. Please use a forward declaration in vgic.h. Regards, -- Julien Grall