All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Qiao Zhou <zhouqiao@marvell.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	zhangfei.gao@gmail.com
Subject: Re: [PATCH] *** ASoC: core: refine of node id parse of cpu/codec dai ***
Date: Wed, 18 Jun 2014 14:13:39 +0200	[thread overview]
Message-ID: <53A18273.7090203@metafoo.de> (raw)
In-Reply-To: <1403089319-2555-1-git-send-email-zhouqiao@marvell.com>

On 06/18/2014 01:01 PM, Qiao Zhou wrote:
> Hi Mark, Liam
>
> This patch is to add another check besides cpu_dai/codec_dai name during
> dai_link bind. currently if the cpu_dai/codec_dai name match corresponding
> dai_link cpu/codec name, then a match is found. in this patch, it also checks
> whether cpu/codec dai id match dailink cpu_dai_id/codec_dai_id. Still check
> name first.
> 1. if it doesn't match, it will keep checking whether cpu_id/codec_id match
> corresponding dai_link cpu_dai_id/codec_dai_id. if the ids are equal, then
> a match is found.
> 2. if it does match, then a match is already found. no need to further check.
>
[...]
> Could you help share your opinions? Thanks in advance.

Hi,

There is already snd_soc_of_get_dai_name() which will translate a phandle + 
specifier to a DAI name. By default it will use the DAI id for the 
specifier. Alternatively the driver can implement a of_xlate_dai_name 
callback that does the translation from specifier to name. The advantage of 
this approach is that the board driver does not need to know about the 
specific format of the DAI specifier.

- Lars

  parent reply	other threads:[~2014-06-18 12:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18 11:01 [PATCH] *** ASoC: core: refine of node id parse of cpu/codec dai *** Qiao Zhou
2014-06-18 11:01 ` [PATCH] ASoC: core: refine of node id parse of cpu/codec dai Qiao Zhou
2014-06-18 12:13 ` Lars-Peter Clausen [this message]
2014-06-19  1:10   ` [PATCH] *** ASoC: core: refine of node id parse of cpu/codec dai *** Qiao Zhou
2014-06-19  5:29     ` Lars-Peter Clausen
2014-06-20  2:32       ` Qiao Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A18273.7090203@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.de \
    --cc=zhangfei.gao@gmail.com \
    --cc=zhouqiao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.