From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT Date: Wed, 18 Jun 2014 18:20:18 +0400 Message-ID: <53A1A022.1020801@cogentembedded.com> References: <87d2e6zjhf.wl%kuninori.morimoto.gx@gmail.com> <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f42.google.com (mail-la0-f42.google.com [209.85.215.42]) by alsa0.perex.cz (Postfix) with ESMTP id 74AD7261A1D for ; Wed, 18 Jun 2014 16:20:13 +0200 (CEST) Received: by mail-la0-f42.google.com with SMTP id pn19so582444lab.29 for ; Wed, 18 Jun 2014 07:20:13 -0700 (PDT) In-Reply-To: <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto , Mark Brown Cc: linux-sh@vger.kernel.org, Linux-ALSA , Simon , Kuninori Morimoto , Liam Girdwood List-Id: alsa-devel@alsa-project.org Hello. On 06/18/2014 12:56 PM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > some special board wants to exchange sampling rate by using SRC. > This patch enables its settings. > Signed-off-by: Kuninori Morimoto [...] > diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c > index 4d39505..93a5e58 100644 > --- a/sound/soc/sh/rcar/src.c > +++ b/sound/soc/sh/rcar/src.c [...] > @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev, > info->src_info = src_info; > info->src_info_nr = nr; > > + i = 0; > + for_each_child_of_node(src_node, np) { > + src_info = info->src_info + i; > + > + of_property_read_u32(src_node, "convert-rate", Are you sure it's 'src_node' here, not 'np'? > + &src_info->convert_rate); > + > + i++; > + } > + WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 18 Jun 2014 14:20:18 +0000 Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT Message-Id: <53A1A022.1020801@cogentembedded.com> List-Id: References: <87d2e6zjhf.wl%kuninori.morimoto.gx@gmail.com> <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kuninori Morimoto , Mark Brown Cc: linux-sh@vger.kernel.org, Linux-ALSA , Simon , Kuninori Morimoto , Liam Girdwood Hello. On 06/18/2014 12:56 PM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > some special board wants to exchange sampling rate by using SRC. > This patch enables its settings. > Signed-off-by: Kuninori Morimoto [...] > diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c > index 4d39505..93a5e58 100644 > --- a/sound/soc/sh/rcar/src.c > +++ b/sound/soc/sh/rcar/src.c [...] > @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev, > info->src_info = src_info; > info->src_info_nr = nr; > > + i = 0; > + for_each_child_of_node(src_node, np) { > + src_info = info->src_info + i; > + > + of_property_read_u32(src_node, "convert-rate", Are you sure it's 'src_node' here, not 'np'? > + &src_info->convert_rate); > + > + i++; > + } > + WBR, Sergei