From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1WxHFN-0007KV-1r
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:54:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1WxHFF-0003gP-Ey
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:53:57 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:56473)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1WxHFF-0003fs-9B
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:53:49 -0400
Message-ID: <53A1A7EF.7090105@imgtec.com>
Date: Wed, 18 Jun 2014 15:53:35 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1401385013-40740-1-git-send-email-petar.jovanovic@rt-rk.com>,
	<20140530080231.GA19124@ohm.rr44.fr>
	<56EA75BA695AE044ACFB41322F6D2BF44D9B61C4@BADAG02.ba.imgtec.org>
In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF44D9B61C4@BADAG02.ba.imgtec.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v4 PATCH] target-mips: implement UserLocal
	Register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Petar Jovanovic <Petar.Jovanovic@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>, Petar Jovanovic <petar.jovanovic@rt-rk.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "afaerber@suse.de" <afaerber@suse.de>, "rth@twiddle.net" <rth@twiddle.net>

Hi Petar,

>> @@ -4214,7 +4215,17 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int reg, int sel)
>>          case 1:
>>  //            gen_helper_mfc0_contextconfig(arg); /* SmartMIPS ASE */
>>              rn = "ContextConfig";
>> +            goto die;
>>  //            break;
>> +        case 2:
>> +            if (ctx->ulri) {
>> +                tcg_gen_ld32s_tl(arg, cpu_env,
>> +                                 offsetof(CPUMIPSState,
>> +                                          active_tc.CP0_UserLocal));
>> +                rn = "UserLocal";
>> +            } else {
>> +                tcg_gen_movi_tl(arg, 0);
>> +            }
>>          default:
>>              goto die;
>>          }

You forgot to put "break" at the end of the case - this leads to
Reserved Instruction exception when trying to read the register.

Regards,
Leon