From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce flags in TCG mode, too
Date: Wed, 18 Jun 2014 17:54:15 +0200 [thread overview]
Message-ID: <53A1B627.7040202@redhat.com> (raw)
In-Reply-To: <53A1B557.4020104@suse.de>
Il 18/06/2014 17:50, Andreas Färber ha scritto:
>>> >> + } else if (tcg_enabled()) {
>>> >> return wi->tcg_features;
>>> >> + } else {
>>> >> + return UINT32_MAX;
>> >
>> > Agreed, but I would prefer writing it as ~0 instead of UINT32_MAX.
> FTR done as ~0u to avoid any signedness issues.
>
FWIW, I find ~0u worse than ~0, because the former expands to 0xffffffff
if x86_cpu_get_supported_feature_word is ever changed to return
uint64_t. The latter instead returns all-ones as desired.
Paolo
next prev parent reply other threads:[~2014-06-18 15:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398876525-28831-1-git-send-email-ehabkost@redhat.com>
[not found] ` <1398876525-28831-3-git-send-email-ehabkost@redhat.com>
2014-05-15 12:21 ` [Qemu-devel] [PATCH v4 02/18] target-i386: Simplify reporting of unavailable features Andreas Färber
2014-05-15 13:39 ` Eduardo Habkost
2014-05-15 16:00 ` Andreas Färber
[not found] ` <1398876525-28831-4-git-send-email-ehabkost@redhat.com>
2014-05-15 13:19 ` [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/checking functions Andreas Färber
[not found] ` <1398876525-28831-8-git-send-email-ehabkost@redhat.com>
2014-05-15 18:10 ` [Qemu-devel] [PATCH v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too Andreas Färber
2014-05-15 18:54 ` Eduardo Habkost
[not found] ` <1398876525-28831-13-git-send-email-ehabkost@redhat.com>
2014-05-15 18:54 ` [Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce flags in TCG mode, too Andreas Färber
2014-05-15 19:12 ` Eduardo Habkost
2014-06-18 15:50 ` Andreas Färber
2014-06-18 15:54 ` Paolo Bonzini [this message]
[not found] ` <1398876525-28831-14-git-send-email-ehabkost@redhat.com>
2014-05-15 19:12 ` [Qemu-devel] [PATCH v4 13/18] target-i386: Support "-cpu host" in TCG mode Andreas Färber
2014-05-15 19:21 ` Eduardo Habkost
[not found] ` <1398876525-28831-15-git-send-email-ehabkost@redhat.com>
2014-05-15 19:44 ` [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model Andreas Färber
2014-05-15 20:26 ` Eduardo Habkost
2014-05-15 22:12 ` Andreas Färber
2014-05-16 16:13 ` Eduardo Habkost
2014-05-16 16:29 ` Andreas Färber
2014-05-16 17:18 ` Eduardo Habkost
[not found] ` <1398876525-28831-16-git-send-email-ehabkost@redhat.com>
2014-05-15 20:07 ` [Qemu-devel] [PATCH v4 15/18] target-i386: Set migratable=yes by default Andreas Färber
2014-05-15 20:22 ` Eduardo Habkost
2014-05-16 11:14 ` Marcelo Tosatti
[not found] ` <1398876525-28831-18-git-send-email-ehabkost@redhat.com>
2014-05-15 20:22 ` [Qemu-devel] [PATCH v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed Andreas Färber
2014-05-16 9:05 ` Andreas Färber
2014-05-16 13:15 ` Luiz Capitulino
2014-05-16 15:36 ` Eduardo Habkost
2014-05-16 17:51 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1B627.7040202@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.