From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] virtio-scsi: fix object check failure
Date: Wed, 18 Jun 2014 18:05:46 +0200 [thread overview]
Message-ID: <53A1B8DA.8010002@redhat.com> (raw)
In-Reply-To: <CACVXFVPYrZL4S-RMBuhNP16Xk4oHDCAGXso0NFod6ENwq1MbDg@mail.gmail.com>
Il 18/06/2014 18:03, Ming Lei ha scritto:
>> >
>> > - initialize them to the existing functions in virtio_scsi_class_init
>> >
>> > - initialize them to dummy empty functions in vhost_scsi_class_init
> But vhost does need the three functions as vq's handle_out callback.
Yes, but they do not need to do anything, the kernel handles everything.
They just cannot be NULL.
Paolo
prev parent reply other threads:[~2014-06-18 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 15:32 [Qemu-devel] [PATCH v1] virtio-scsi: fix object check failure Ming Lei
2014-06-18 15:43 ` Michael S. Tsirkin
2014-06-18 15:48 ` Ming Lei
2014-06-18 15:53 ` Paolo Bonzini
2014-06-18 16:03 ` Ming Lei
2014-06-18 16:05 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1B8DA.8010002@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.