From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Panic when we receive an unexpected trap Date: Wed, 18 Jun 2014 17:08:19 +0100 Message-ID: <53A1B973.20805@linaro.org> References: <1403037868-18158-1-git-send-email-julien.grall@linaro.org> <1403107337.6568.110.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxIPP-0001OD-BI for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 16:08:23 +0000 Received: by mail-we0-f181.google.com with SMTP id q59so1091701wes.40 for ; Wed, 18 Jun 2014 09:08:22 -0700 (PDT) In-Reply-To: <1403107337.6568.110.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 06/18/2014 05:02 PM, Ian Campbell wrote: > On Tue, 2014-06-17 at 21:44 +0100, Julien Grall wrote: >> The current implementation of do_unexpected_trap make Xen spin forever >> on the current physical CPU. This may lead to stall guests VCPU and print >> unhelpful message (RCU stall...). >> >> Usually when Xen receives an unexpected trap, it means that something goes >> wrong either in the hypervisor or in the CPU. In this case we should >> directly panic to also stop the other CPUs. >> >> Signed-off-by: Julien Grall > > Ack + applied. Thanks, I think this patch is a good candidate for backporting on Xen 4.4 It will avoid Xen to try to continue running when an unexpected trap occurs. Regards, -- Julien Grall