From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIxq-00014Y-DT for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxIxi-0002JY-UL for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:43:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56393 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIxi-0002JT-Ni for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:43:50 -0400 Message-ID: <53A1C1C5.4020608@suse.de> Date: Wed, 18 Jun 2014 18:43:49 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1403108653-26765-1-git-send-email-akong@redhat.com> <1403108653-26765-4-git-send-email-akong@redhat.com> In-Reply-To: <1403108653-26765-4-git-send-email-akong@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop() to virtblk_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org, Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, arei.gonglei@huawei.com Am 18.06.2014 18:24, schrieb Amos Kong: > I want to add a new subtest in virtio-blk-test.c, it will start > guest without network. The original pci_init() did nothing, but > it's good to reserve a very simple initialization testing. >=20 > Signed-off-by: Amos Kong > Reviewed-by: Stefan Hajnoczi > --- > tests/virtio-blk-test.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c > index d53f875..0fdec01 100644 > --- a/tests/virtio-blk-test.c > +++ b/tests/virtio-blk-test.c > @@ -12,9 +12,12 @@ > #include "libqtest.h" > #include "qemu/osdep.h" > =20 > -/* Tests only initialization so far. TODO: Replace with functional tes= ts */ One thing of note here is that this TODO is neither resolved here nor later in this series. Stefan had originally asked me to add it. Andreas > -static void pci_nop(void) > +/* Tests only initialization */ > +static void virtblk_init(void) > { > + qtest_start("-drive id=3Ddrv0,if=3Dnone,file=3D/dev/null " > + "-device virtio-blk-pci,drive=3Ddrv0"); > + qtest_end(); > } > =20 > int main(int argc, char **argv) [snip] --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg