From: Julien Grall <julien.grall@linaro.org>
To: Thomas Leonard <talex5@gmail.com>, xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com,
Dave.Scott@eu.citrix.com, anil@recoil.org
Subject: Re: [PATCH ARM v4 12/12] mini-os: added ARM grant table initialisation
Date: Wed, 18 Jun 2014 18:27:49 +0100 [thread overview]
Message-ID: <53A1CC15.4050506@linaro.org> (raw)
In-Reply-To: <1403104106-32538-13-git-send-email-talex5@gmail.com>
Hi Thomas,
On 06/18/2014 04:08 PM, Thomas Leonard wrote:
> +
> +/* Get Xen's sugggested physical page assignments for the grant table. */
> +static grant_entry_t *get_gnttab_base(void)
> +{
> + int hypervisor;
> +
> + hypervisor = fdt_path_offset(device_tree, "/hypervisor");
Same comment as on patch #11, you need to search the hypervisor node via
the compatible string.
> index 2f1b3d7..f395d12 100644
> --- a/extras/mini-os/gnttab.c
> +++ b/extras/mini-os/gnttab.c
> @@ -164,7 +164,7 @@ gnttabop_error(int16_t status)
> {
> status = -status;
> if (status < 0 || status >= ARRAY_SIZE(gnttabop_error_msgs))
> - return "bad status";
> + return "bad status";
Spurious change?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-06-18 17:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 15:08 [PATCH ARM v4 00/12] mini-os: initial ARM support Thomas Leonard
2014-06-18 15:08 ` [PATCH ARM v4 01/12] mini-os: build fixes Thomas Leonard
2014-06-18 16:26 ` Ian Campbell
2014-06-18 17:41 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 02/12] mini-os: fixed shutdown thread Thomas Leonard
2014-06-18 15:08 ` [PATCH ARM v4 03/12] mini-os: fixed format string error in unbind_evtchn Thomas Leonard
2014-06-18 16:28 ` Ian Campbell
2014-06-18 17:42 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 04/12] mini-os: use unbind_evtchn in unbind_all_ports Thomas Leonard
2014-06-18 16:30 ` Ian Campbell
2014-06-18 17:44 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 05/12] mini-os: made off_t type signed Thomas Leonard
2014-06-18 16:31 ` Ian Campbell
2014-06-18 17:44 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 06/12] mini-os: switched initial C entry point to arch_init Thomas Leonard
2014-06-18 15:08 ` [PATCH ARM v4 07/12] mini-os: initial ARM support Thomas Leonard
2014-06-18 17:48 ` Samuel Thibault
2014-06-18 22:40 ` Julien Grall
2014-06-23 15:10 ` Thomas Leonard
2014-06-23 16:55 ` Julien Grall
2014-06-23 22:33 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 08/12] mini-os: arm: show registers, stack and exception vector on fault Thomas Leonard
2014-06-18 15:08 ` [PATCH ARM v4 09/12] mini-os: import libfdt Thomas Leonard
2014-06-18 18:02 ` Samuel Thibault
2014-06-18 15:08 ` [PATCH ARM v4 10/12] mini-os: get RAM base and size from the FDT Thomas Leonard
2014-06-18 17:38 ` Julien Grall
2014-06-19 8:39 ` Thomas Leonard
2014-06-19 11:24 ` Julien Grall
2014-07-02 15:51 ` Ian Campbell
2014-06-18 15:08 ` [PATCH ARM v4 11/12] mini-os: get GIC addresses from FDT Thomas Leonard
2014-06-18 17:25 ` Julien Grall
2014-06-19 8:50 ` Thomas Leonard
2014-06-19 10:58 ` Julien Grall
2014-06-19 16:14 ` Thomas Leonard
2014-06-19 16:20 ` Julien Grall
2014-07-02 15:55 ` Ian Campbell
2014-06-18 15:08 ` [PATCH ARM v4 12/12] mini-os: added ARM grant table initialisation Thomas Leonard
2014-06-18 17:27 ` Julien Grall [this message]
2014-06-25 16:41 ` Thomas Leonard
2014-06-25 16:50 ` Ian Campbell
2014-06-18 18:05 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1CC15.4050506@linaro.org \
--to=julien.grall@linaro.org \
--cc=Dave.Scott@eu.citrix.com \
--cc=anil@recoil.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=talex5@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.