From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH ARM v4 12/12] mini-os: added ARM grant table initialisation Date: Wed, 18 Jun 2014 18:27:49 +0100 Message-ID: <53A1CC15.4050506@linaro.org> References: <1403104106-32538-1-git-send-email-talex5@gmail.com> <1403104106-32538-13-git-send-email-talex5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxJeL-0001Pv-Fo for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 17:27:53 +0000 Received: by mail-wi0-f182.google.com with SMTP id bs8so1547706wib.15 for ; Wed, 18 Jun 2014 10:27:52 -0700 (PDT) In-Reply-To: <1403104106-32538-13-git-send-email-talex5@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Thomas Leonard , xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com, Dave.Scott@eu.citrix.com, anil@recoil.org List-Id: xen-devel@lists.xenproject.org Hi Thomas, On 06/18/2014 04:08 PM, Thomas Leonard wrote: > + > +/* Get Xen's sugggested physical page assignments for the grant table. */ > +static grant_entry_t *get_gnttab_base(void) > +{ > + int hypervisor; > + > + hypervisor = fdt_path_offset(device_tree, "/hypervisor"); Same comment as on patch #11, you need to search the hypervisor node via the compatible string. > index 2f1b3d7..f395d12 100644 > --- a/extras/mini-os/gnttab.c > +++ b/extras/mini-os/gnttab.c > @@ -164,7 +164,7 @@ gnttabop_error(int16_t status) > { > status = -status; > if (status < 0 || status >= ARRAY_SIZE(gnttabop_error_msgs)) > - return "bad status"; > + return "bad status"; Spurious change? Regards, -- Julien Grall