Re: [Qemu-devel] [PATCH 2.1 07/36] monitor: add an implemention of qapi event emit method

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
> From: Wenchao Xia <wenchaoqemu@gmail.com>
> 
> The monitor is now hooked on the new event mechanism, so that later
> patches can convert event callers one by one. Most code are copied from
> old monitor_protocol_* functions with some modification.
> 
> Note that two build time warnings will be raised after this patch. One is
> caused by no caller of monitor_qapi_event_throttle(), the other one is
> caused by QAPI_EVENT_MAX = 0. They will be fixed automatically after
> full event conversion later.

This comment is now stale, given...

> 
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  monitor.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 127 insertions(+), 1 deletion(-)

> + * milliseconds
> + */
> +static void __attribute__((__unused__))
> +monitor_qapi_event_throttle(QAPIEvent event, int64_t rate)

>   */
> -static void
> +static void __attribute__((__unused__))
>  monitor_protocol_event_throttle(MonitorEvent event,
>                                  int64_t rate)

...these workarounds.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]