From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liu Ying Subject: Re: [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype Date: Thu, 19 Jun 2014 15:24:07 +0800 Message-ID: <53A29017.3040905@freescale.com> References: <1403146231-28970-1-git-send-email-Ying.Liu@freescale.com> <20140619070119.GN5821@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2lp0238.outbound.protection.outlook.com [207.46.163.238]) by gabe.freedesktop.org (Postfix) with ESMTP id ED7726E124 for ; Thu, 19 Jun 2014 00:21:11 -0700 (PDT) In-Reply-To: <20140619070119.GN5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 06/19/2014 03:01 PM, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote: >> The return type of drm_fb_helper_debug_enter() is int, so we should return '0' >> instead of 'false'. >> >> Signed-off-by: Liu Ying >> --- >> drivers/gpu/drm/drm_fb_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c >> index d5d8cea..8daa4ad 100644 >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info) >> int i; >> >> if (list_empty(&kernel_fb_helper_list)) >> - return false; >> + return 0; > > Actually we can remove the entire if check since list_for_each_entry is a > no-op on an empty list, and then we'll fall right through to the return 0; > at the end of the function. Care to respin your patch? > -Daniel Ok, I will respin my patch. Thanks. Liu Ying > >> >> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) { >> for (i = 0; i < helper->crtc_count; i++) { >> -- >> 1.7.9.5 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel >