From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>, arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, luonengjun@huawei.com,
qemu-devel@nongnu.org, stefanha@redhat.com, akong@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases
Date: Thu, 19 Jun 2014 14:24:34 +0200 [thread overview]
Message-ID: <53A2D682.1010903@suse.de> (raw)
In-Reply-To: <1403172316.22530.8.camel@nilsson.home.kraxel.org>
Hi Gerd,
Am 19.06.2014 12:05, schrieb Gerd Hoffmann:
>> Gonglei (5):
>> tests: add OHCI qtest
>> tests: add UHCI qtest
>> tests: add xHCI qtest
>> usb-hcd-ehci-test: change ehci qtest more expansively
>> usb-hcd-ehci-test: add ehci hotplug/unplug qtest
>
> I'd prefer to leave the usb-hcd-ehci-test alone.
Why? My idea was to put all EHCI testing code into that ehci file. This
is so that any defines or helper functions can be shared within the
file. Functional testing of the companion core should go into the
respective *hci file, unless there is some interaction to test.
Just because right now most test files are pretty empty doesn't mean
they need to stay that way.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-06-19 12:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 8:03 [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases arei.gonglei
2014-06-17 8:03 ` [Qemu-devel] [PATCH 1/5] tests: add OHCI qtest arei.gonglei
2014-06-19 12:34 ` Andreas Färber
2014-06-19 12:48 ` Gonglei (Arei)
2014-06-17 8:04 ` [Qemu-devel] [PATCH 2/5] tests: add UHCI qtest arei.gonglei
2014-06-19 12:40 ` Andreas Färber
2014-06-19 12:59 ` Gonglei (Arei)
2014-06-17 8:04 ` [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest arei.gonglei
2014-06-19 12:37 ` Andreas Färber
2014-06-19 12:57 ` Gonglei (Arei)
2014-06-17 8:04 ` [Qemu-devel] [PATCH 4/5] usb-hcd-ehci-test: change ehci qtest more expansively arei.gonglei
2014-06-19 12:55 ` Andreas Färber
2014-06-17 8:04 ` [Qemu-devel] [PATCH 5/5] usb-hcd-ehci-test: add ehci hotplug/unplug qtest arei.gonglei
2014-06-19 10:05 ` [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases Gerd Hoffmann
2014-06-19 12:18 ` Gonglei (Arei)
2014-06-19 12:24 ` Andreas Färber [this message]
2014-06-19 12:47 ` Gerd Hoffmann
2014-06-19 13:07 ` Andreas Färber
2014-06-19 13:19 ` Gonglei (Arei)
2014-06-19 13:33 ` Andreas Färber
2014-06-19 13:46 ` Gerd Hoffmann
2014-06-20 1:51 ` Gonglei (Arei)
2014-06-20 1:48 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2D682.1010903@suse.de \
--to=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=luonengjun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.