From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxc3s-00030W-5p for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:07:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxc3j-0001oI-Be for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:07:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46427 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxc3j-0001oC-5T for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:07:19 -0400 Message-ID: <53A2E084.5050708@suse.de> Date: Thu, 19 Jun 2014 15:07:16 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1402992243-10224-1-git-send-email-arei.gonglei@huawei.com> <1403172316.22530.8.camel@nilsson.home.kraxel.org> <53A2D682.1010903@suse.de> <1403182025.22530.13.camel@nilsson.home.kraxel.org> In-Reply-To: <1403182025.22530.13.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: weidong.huang@huawei.com, luonengjun@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, stefanha@redhat.com, akong@redhat.com Am 19.06.2014 14:47, schrieb Gerd Hoffmann: > Maybe it makes sense to have a usb-hcd-hotplug-test.c file and collect > hotplug testing for all usb hcds we have there. For code sharing > that'll be better for sure as the basic code flow is the same for all > hcd types. Ah yes, seeing that there is a "global" QEMU instance in 4/5, that may make more sense. OTOH hot-plug testing is a recurring topic for all PCI devices and won't work in general (e.g., virtio-blk needs drive), but maybe we can factor out some helpers to a .h file. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg