From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: hutao@cn.fujitsu.com, mst@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend
Date: Thu, 19 Jun 2014 07:41:29 -0600 [thread overview]
Message-ID: <53A2E889.5050503@redhat.com> (raw)
In-Reply-To: <1403185072-24598-1-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On 06/19/2014 07:37 AM, Igor Mammedov wrote:
> fixup documentation comments and HMP message/help text
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> PS: based on PCI tree
> ---
> hmp.c | 2 +-
> monitor.c | 2 +-
> qapi-schema.json | 11 ++++++-----
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
> # Since: 2.1
> ##
> { 'command': 'query-memdev', 'returns': ['Memdev'] }
> +
> # @PCDIMMDeviceInfo:
Can you also add a ## lead-in to PCDIMMDeviceInfo? The rest of the file
is fairly consistent at:
##
# docs
##
{ ... }
With that line added,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-06-19 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 13:37 [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend Igor Mammedov
2014-06-19 13:41 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2E889.5050503@redhat.com \
--to=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.