From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Etheridge Subject: Re: [PATCH/RESEND 0/9] drm: tilcdc driver fixes Date: Thu, 19 Jun 2014 08:41:43 -0500 Message-ID: <53A2E897.1030206@ti.com> References: <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar> <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?R3VpZG8gTWFydMOtbmV6?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Cc: Daniel Vetter , Russell King , =?UTF-8?B?RXplcXVpZWwgR2FyY8OtYQ==?= , Daniel Mack List-Id: linux-omap@vger.kernel.org R3VpZG8sCgpUaGFua3MgYW5kIHNvcnJ5IEkgbWlzc2VkIHRoaXMgdGhlIGZpcnN0IHRpbWUgYXJv dW5kLiAgSSdsbCBnaXZlIGl0IGEgCnRyeSBvbiBhIGZldyBvZiBteSBBTTMzNXggYmFzZWQgYm9h cmRzIHdoZW4gSSBoYXZlIGFjY2VzcyB0byB0aGVtIGFnYWluIApvbiBNb25kYXkuCgpEYXJyZW4K Ck9uIDA2LzE3LzIwMTQgMDk6MTcgQU0sIEd1aWRvIE1hcnTDrW5leiB3cm90ZToKPiBUaGUgdGls Y2RjIGRyaXZlciBjb3VsZCBiZSBjb21waWxlZCBhcyBhIG1vZHVsZSwgYnV0IHdhcyBzZXZlcmVs eSBicm9rZW4KPiBhbmQgY291bGQgbm90IGJlIHVzZWQgYXMgc3VjaC4gVGhpcyBwYXRjaHNldCBh dHRlbXB0cyB0byBmaXggdGhlIGlzc3Vlcwo+IHByZXZlbnRpbmcgYSBwcm9wZXIgbG9hZC91bmxv YWQgb2YgdGhlIG1vZHVsZS4KPgo+IElzc3VlcyBpbmNsdWRlZCBkYW5nbGluZyBzeXNmcyBub2Rl cywgZGFuZ2xpbmcgZGV2aWNlcywgbWVtb3J5IGxlYWtzIGFuZAo+IGEgZG91YmxlIGtmcmVlLgo+ Cj4gSXQgbm93IHNlZW1zIHRvIGJlIHdvcmtpbmcgb2suIFdlIGhhdmUgdGVzdGVkIHRoaXMgYnkg bG9hZGluZyBhbmQKPiB1bmxvYWRpbmcgdGhlIGRyaXZlciByZXBldGVhZGx5LCB3aXRoIGJvdGgg cGFuZWwgYW5kIHNsYXZlIGNvbm5lY3RvcnMKPiBhbmQgZm91bmQgbm8gZmxhd3MuCj4KPiBUaGVy ZSBpcyBzdGlsbCBvbmUgd2FybmluZyBsZWZ0IG9uIHRpbGNkY19jcnRjX2Rlc3Ryb3ksIGNhdXNl ZCBieQo+IGRlc3Ryb3lpbmcgdGhlIGNvbm5lY3RvciB3aGlsZSBzdGlsbCBpbiBhbiBPTiBzdGF0 dXMuIFdlIGRvbid0IGtub3cgd2h5Cj4gdGhpcyBoYXBwZW5zIG9yIHdoeSBpdCdzIGFuIGlzc3Vl LCBzbyB3ZSBkaWQgbm90IGZpeCBpdC4KPgo+IFRoZSBmaXJzdCA3IHBhdGNoZXMgYXJlIGJ1ZyBm aXhlcyB3aGljaCBhbmQgc2hvdWxkIHByb2JhYmx5IGJlIGFwcGxpZWQKPiBpbiB0aGUgc3RhYmxl IHRyZWVzLiBUaGUgbGFzdCB0d28gYXJlIGNsZWFuLXVwcy4KPgo+Cj4gUmVzZW5kaW5nIHRoaXMg c2luY2UgSSBnb3Qgbm8gcmVwbGllcy4KPgo+Cj4gR3VpZG8gTWFydMOtbmV6ICg5KToKPiAgICBk cm0vaTJjOiB0ZGE5OTh4OiBtb3ZlIGRybV9pMmNfZW5jb2Rlcl9kZXN0cm95IGNhbGwKPiAgICBk cm0vdGlsY2RjOiBwYW5lbDogZml4IGRhbmdsaW5nIHN5c2ZzIGNvbm5lY3RvciBub2RlCj4gICAg ZHJtL3RpbGNkYzogc2xhdmU6IGZpeCBkYW5nbGluZyBzeXNmcyBjb25uZWN0b3Igbm9kZQo+ICAg IGRybS90aWxjZGM6IHRmcDQxMDogZml4IGRhbmdsaW5nIHN5c2ZzIGNvbm5lY3RvciBub2RlCj4g ICAgZHJtL3RpbGNkYzogcGFuZWw6IGZpeCBsZWFrIHdoZW4gdW5sb2FkaW5nIHRoZSBtb2R1bGUK PiAgICBkcm0vdGlsY2RjOiBmaXggcmVsZWFzZSBvcmRlciBvbiBleGl0Cj4gICAgZHJtL3RpbGNk YzogZml4IGRvdWJsZSBrZnJlZQo+ICAgIGRybS90aWxjZGM6IHJlbW92ZSBzdWJtb2R1bGUgZGVz dHJveSBjYWxscwo+ICAgIGRybS90aWxjZGM6IHJlcGxhY2UgbGF0ZV9pbml0Y2FsbCB3aXRoIG1v ZHVsZV9pbml0Cj4KPiAgIGRyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYyAgICAgIHwg IDIgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvTW9kdWxlLnN5bXZlcnMgIHwgIDAKPiAg IGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX2Rydi5jICAgIHwgMTUgKysrKystLS0tLS0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfZHJ2LmggICAgfCAgMSAtCj4gICBk cml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19wYW5lbC5jICB8IDM5ICsrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX3Ns YXZlLmMgIHwgMjcgKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS90 aWxjZGMvdGlsY2RjX3RmcDQxMC5jIHwgMzUgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t Cj4gICA3IGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDYwIGRlbGV0aW9ucygtKQo+ ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvTW9kdWxlLnN5bXZl cnMKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: detheridge@TI.COM (Darren Etheridge) Date: Thu, 19 Jun 2014 08:41:43 -0500 Subject: [PATCH/RESEND 0/9] drm: tilcdc driver fixes In-Reply-To: <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> References: <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar> <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar> Message-ID: <53A2E897.1030206@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Guido, Thanks and sorry I missed this the first time around. I'll give it a try on a few of my AM335x based boards when I have access to them again on Monday. Darren On 06/17/2014 09:17 AM, Guido Mart?nez wrote: > The tilcdc driver could be compiled as a module, but was severely broken > and could not be used as such. This patchset attempts to fix the issues > preventing a proper load/unload of the module. > > Issues included dangling sysfs nodes, dangling devices, memory leaks and > a double kfree. > > It now seems to be working ok. We have tested this by loading and > unloading the driver repeteadly, with both panel and slave connectors > and found no flaws. > > There is still one warning left on tilcdc_crtc_destroy, caused by > destroying the connector while still in an ON status. We don't know why > this happens or why it's an issue, so we did not fix it. > > The first 7 patches are bug fixes which and should probably be applied > in the stable trees. The last two are clean-ups. > > > Resending this since I got no replies. > > > Guido Mart?nez (9): > drm/i2c: tda998x: move drm_i2c_encoder_destroy call > drm/tilcdc: panel: fix dangling sysfs connector node > drm/tilcdc: slave: fix dangling sysfs connector node > drm/tilcdc: tfp410: fix dangling sysfs connector node > drm/tilcdc: panel: fix leak when unloading the module > drm/tilcdc: fix release order on exit > drm/tilcdc: fix double kfree > drm/tilcdc: remove submodule destroy calls > drm/tilcdc: replace late_initcall with module_init > > drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- > drivers/gpu/drm/tilcdc/Module.symvers | 0 > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 +++++-------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 - > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 39 +++++++++++++++++----------------- > drivers/gpu/drm/tilcdc/tilcdc_slave.c | 27 +++++++++++++---------- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 35 +++++++++++++++--------------- > 7 files changed, 59 insertions(+), 60 deletions(-) > create mode 100644 drivers/gpu/drm/tilcdc/Module.symvers >