Re: [PATCH ARM v4 11/12] mini-os: get GIC addresses from FDT

[Julien Grall <julien.grall@linaro.org>]

On 06/19/2014 05:14 PM, Thomas Leonard wrote:
> On 19 June 2014 11:58, Julien Grall <julien.grall@linaro.org> wrote:
>> On 06/19/2014 09:50 AM, Thomas Leonard wrote:
>>> On 18 June 2014 18:25, Julien Grall <julien.grall@linaro.org> wrote:
>>>> Hi Thomas,
>>>>
>>>> On 06/18/2014 04:08 PM, Thomas Leonard wrote:
>>>>>  //#define VGIC_DEBUG
>>>>>  #ifdef VGIC_DEBUG
>>>>> @@ -168,9 +169,38 @@ static void gic_handler(void) {
>>>>>  }
>>>>>
>>>>>  void gic_init(void) {
>>>>> -    // FIXME Get from dt!
>>>>> -    gic.gicd_base = (char *)0x2c001000ULL;
>>>>> -    gic.gicc_base = (char *)0x2c002000ULL;
>>>>> +    gic.gicd_base = NULL;
>>>>
>>>> Any reason to not fold this patch in patch #7? Or better move the gic
>>>> code in a separate patch?
>>>
>>> It was previously requested that I split the FDT patch from the main
>>> ARM one. This patch depends on libfdt being present, so it has to go
>>> after that.
>>
>> Please make sure that this "standalone patch" works correctly on Xen
>> unstable...
> 
> OK, I can make it use GUEST_GICD_BASE/GUEST_GICC_BASE (with a FIXME)
> so that the first commit works on unstable.

This 2 defines are only exposed to XEN and XEN tools. I don't think you
will be able to use it for mini-os.

> I tried installing the unstable version (staging branch) of Xen to
> test it, but for some reason it didn't work:
> 
> # LD_LIBRARY_PATH=/opt/xen-4.5-unstable/lib/ /opt/xen-4.5-unstable/sbin/xl dmesg
> xc: error: Could not obtain handle on privileged command interface (2
> = No such file or directory): Internal error
> libxl: error: libxl.c:99:libxl_ctx_alloc: cannot open libxc handle: No
> such file or directory
> cannot init xl context
> 
> It tries to open "/proc/xen/privcmd", which doesn't exist. Maybe I
> need a newer Linux kernel? That could be tricky, as I'm using a
> special fork for this board.

Did you start xencommons?

/etc/init.d/xencommons start

Regards,

-- 
Julien Grall