From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH ARM v4 11/12] mini-os: get GIC addresses
 from FDT
Date: Thu, 19 Jun 2014 17:20:09 +0100
Message-ID: <53A30DB9.3090604@linaro.org>
References: <1403104106-32538-1-git-send-email-talex5@gmail.com>	<1403104106-32538-12-git-send-email-talex5@gmail.com>	<53A1CB6F.4050209@linaro.org>	<CAG4opy_1Hi=0UrD+rnCdU9DjSXR6UgrOTOBLvifqF5SSbqP2-w@mail.gmail.com>	<53A2C23F.4050902@linaro.org>
	<CAG4opy_1uCs5A-CZbCe43FVyn_LHTL1wr-vsA0PaDx4ZPOj7_Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1Wxf4P-0003gI-Jt
	for xen-devel@lists.xenproject.org; Thu, 19 Jun 2014 16:20:14 +0000
Received: by mail-we0-f178.google.com with SMTP id x48so2567388wes.37
	for <xen-devel@lists.xenproject.org>;
	Thu, 19 Jun 2014 09:20:12 -0700 (PDT)
In-Reply-To: <CAG4opy_1uCs5A-CZbCe43FVyn_LHTL1wr-vsA0PaDx4ZPOj7_Q@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, David Scott <Dave.Scott@eu.citrix.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Anil Madhavapeddy <anil@recoil.org>
List-Id: xen-devel@lists.xenproject.org

On 06/19/2014 05:14 PM, Thomas Leonard wrote:
> On 19 June 2014 11:58, Julien Grall <julien.grall@linaro.org> wrote:
>> On 06/19/2014 09:50 AM, Thomas Leonard wrote:
>>> On 18 June 2014 18:25, Julien Grall <julien.grall@linaro.org> wrote:
>>>> Hi Thomas,
>>>>
>>>> On 06/18/2014 04:08 PM, Thomas Leonard wrote:
>>>>>  //#define VGIC_DEBUG
>>>>>  #ifdef VGIC_DEBUG
>>>>> @@ -168,9 +169,38 @@ static void gic_handler(void) {
>>>>>  }
>>>>>
>>>>>  void gic_init(void) {
>>>>> -    // FIXME Get from dt!
>>>>> -    gic.gicd_base = (char *)0x2c001000ULL;
>>>>> -    gic.gicc_base = (char *)0x2c002000ULL;
>>>>> +    gic.gicd_base = NULL;
>>>>
>>>> Any reason to not fold this patch in patch #7? Or better move the gic
>>>> code in a separate patch?
>>>
>>> It was previously requested that I split the FDT patch from the main
>>> ARM one. This patch depends on libfdt being present, so it has to go
>>> after that.
>>
>> Please make sure that this "standalone patch" works correctly on Xen
>> unstable...
> 
> OK, I can make it use GUEST_GICD_BASE/GUEST_GICC_BASE (with a FIXME)
> so that the first commit works on unstable.

This 2 defines are only exposed to XEN and XEN tools. I don't think you
will be able to use it for mini-os.

> I tried installing the unstable version (staging branch) of Xen to
> test it, but for some reason it didn't work:
> 
> # LD_LIBRARY_PATH=/opt/xen-4.5-unstable/lib/ /opt/xen-4.5-unstable/sbin/xl dmesg
> xc: error: Could not obtain handle on privileged command interface (2
> = No such file or directory): Internal error
> libxl: error: libxl.c:99:libxl_ctx_alloc: cannot open libxc handle: No
> such file or directory
> cannot init xl context
> 
> It tries to open "/proc/xen/privcmd", which doesn't exist. Maybe I
> need a newer Linux kernel? That could be tricky, as I'm using a
> special fork for this board.

Did you start xencommons?

/etc/init.d/xencommons start

Regards,

-- 
Julien Grall