From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v3 2/5] configure: make the libaio test
 conditional on blktap{1, 2}
Date: Thu, 19 Jun 2014 19:46:17 +0200
Message-ID: <53A321E9.2090406@citrix.com>
References: <1403195568-19464-1-git-send-email-roger.pau@citrix.com>
	<1403195568-19464-3-git-send-email-roger.pau@citrix.com>
	<20140619173531.GR20819@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WxgPn-0000Eg-9Q
	for xen-devel@lists.xenproject.org; Thu, 19 Jun 2014 17:46:23 +0000
In-Reply-To: <20140619173531.GR20819@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 19/06/14 19:35, Wei Liu wrote:
> On Thu, Jun 19, 2014 at 06:32:45PM +0200, Roger Pau Monne wrote:
>> libaio is only required for blktap{1,2}, so make the check conditional
>> on whether the user has requested blktap{1,2} or not.
>>
>> Signed-off-by: Roger Pau Monn=E9 <roger.pau@citrix.com>
>> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> ---
>> Please re-run autoconf after applying this patch.
>> ---
>> Changes since v2:
>>  - Make libaio test conditional on whether blktap2 is also enabled.
>> ---
>>  tools/configure.ac |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/tools/configure.ac b/tools/configure.ac
>> index 836bbba..6d70f04 100644
>> --- a/tools/configure.ac
>> +++ b/tools/configure.ac
>> @@ -262,7 +262,9 @@ AC_CHECK_HEADER([lzo/lzo1x.h], [
>>  AC_CHECK_LIB([lzo2], [lzo1x_decompress], [zlib=3D"$zlib -DHAVE_LZO1X -l=
lzo2"])
>>  ])
>>  AC_SUBST(zlib)
>> +AS_IF([test "x$enable_blktap1" =3D "xyes" || test "x$enable_blktap2" =
=3D "xyes"], [
>>  AC_CHECK_LIB([aio], [io_setup], [], [AC_MSG_ERROR([Could not find libai=
o])])
>> +])
> =

> Libaio is needed by QEMU as well.

Not on FreeBSD, and Qemu already runs it's own configure script, so I
don't think we need to check for everything that Qemu needs here.

Roger.