Re: [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size()

["Cristian Rodríguez" <crrodriguez@opensuse.org>]

El jue 19 jun 2014 17:08:21 CLT, Lucas De Marchi escribió:
> On Wed, Jun 18, 2014 at 9:51 PM, Cristian Rodríguez
> <crrodriguez@opensuse.org> wrote:
>> ---
>>  libkmod/libkmod-module.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
>> index 1d90f34..8046262 100644
>> --- a/libkmod/libkmod-module.c
>> +++ b/libkmod/libkmod-module.c
>> @@ -1781,7 +1781,7 @@ KMOD_EXPORT long kmod_module_get_size(const struct kmod_module *mod)
>>          * loaded.
>>          */
>>         snprintf(line, sizeof(line), "/sys/module/%s", mod->name);
>> -       dfd = open(line, O_RDONLY);
>> +       dfd = open(line, O_RDONLY|O_CLOEXEC);
>>         if (dfd < 0)
>>                 return -errno;
>>
>> --
>
> I don't know what's  the RESEND in the subject, but the patch looks
> good. I removed it and applied.
>
> Thanks.
>

That means I sent it before months ago but didn't get an answer and/or 
it applied.


--
Cristian
"I don't know the key to success, but the key to failure is trying to 
please everybody."