From: Chanwoo Choi <cw00.choi@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'MyungJoo Ham'" <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org,
"'Graeme Gregory'" <gg@slimlogic.co.uk>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>
Subject: Re: [PATCH] extcon: palmas: Make of_device_id array const
Date: Fri, 20 Jun 2014 10:08:04 +0900 [thread overview]
Message-ID: <53A38974.90903@samsung.com> (raw)
In-Reply-To: <000301cf8ab6$02ebea10$08c3be30$%han@samsung.com>
Hi Jingoo,
On 06/18/2014 02:27 PM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions handle
> it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/extcon/extcon-palmas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 7417ce8..5efa96c 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -278,7 +278,7 @@ static int palmas_usb_resume(struct device *dev)
>
> static SIMPLE_DEV_PM_OPS(palmas_pm_ops, palmas_usb_suspend, palmas_usb_resume);
>
> -static struct of_device_id of_palmas_match_tbl[] = {
> +static const struct of_device_id of_palmas_match_tbl[] = {
> { .compatible = "ti,palmas-usb", },
> { .compatible = "ti,palmas-usb-vid", },
> { .compatible = "ti,twl6035-usb", },
>
The same patch was applied by Krzysztof Kozlowski on extcon-next branch.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2014-06-20 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 5:27 [PATCH] extcon: palmas: Make of_device_id array const Jingoo Han
2014-06-20 1:08 ` Chanwoo Choi [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-23 9:03 Krzysztof Kozlowski
2014-05-28 4:43 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A38974.90903@samsung.com \
--to=cw00.choi@samsung.com \
--cc=gg@slimlogic.co.uk \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.