From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 20 Jun 2014 12:50:52 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:45365 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6817074AbaFTKurRwkTL (ORCPT ); Fri, 20 Jun 2014 12:50:47 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 83AEBC847F83B; Fri, 20 Jun 2014 11:50:38 +0100 (IST) Received: from KLMAIL02.kl.imgtec.org (192.168.5.97) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Fri, 20 Jun 2014 11:50:40 +0100 Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by klmail02.kl.imgtec.org (192.168.5.97) with Microsoft SMTP Server (TLS) id 14.3.181.6; Fri, 20 Jun 2014 11:50:40 +0100 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 20 Jun 2014 11:50:39 +0100 Message-ID: <53A411FF.5070505@imgtec.com> Date: Fri, 20 Jun 2014 11:50:39 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Sorin Dumitru , , CC: Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall References: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com> <53A404D2.3030303@imgtec.com> <53A40FB0.2020503@ixiacom.com> In-Reply-To: <53A40FB0.2020503@ixiacom.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40646 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 20/06/14 11:40, Sorin Dumitru wrote: > On 06/20/14 12:54, James Hogan wrote: >> On 20/06/14 08:53, Sorin Dumitru wrote: >>> Signed-off-by: Sorin Dumitru >> >> A little more commit message wouldn't hurt. Did it break a particular >> program? > > Yes, it was found by an internal program trying to get IP_PKTOPTIONS on > a cavium octeon board. > > Should I resubmit stating what was broken in the commit message? Yeh, if you don't mind. I think it's useful to know exactly why a change was made and what it fixes when later digging through the git history (e.g. commit 515c7af85ed9 is a great example of that). Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:45365 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6817074AbaFTKurRwkTL (ORCPT ); Fri, 20 Jun 2014 12:50:47 +0200 Message-ID: <53A411FF.5070505@imgtec.com> Date: Fri, 20 Jun 2014 11:50:39 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall References: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com> <53A404D2.3030303@imgtec.com> <53A40FB0.2020503@ixiacom.com> In-Reply-To: <53A40FB0.2020503@ixiacom.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Sorin Dumitru , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Cc: ralf@linux-mips.org Message-ID: <20140620105039.j26bPqpJQsLG2WBlc4z_Dbisa2-OPhg3xMpA03Parfs@z> On 20/06/14 11:40, Sorin Dumitru wrote: > On 06/20/14 12:54, James Hogan wrote: >> On 20/06/14 08:53, Sorin Dumitru wrote: >>> Signed-off-by: Sorin Dumitru >> >> A little more commit message wouldn't hurt. Did it break a particular >> program? > > Yes, it was found by an internal program trying to get IP_PKTOPTIONS on > a cavium octeon board. > > Should I resubmit stating what was broken in the commit message? Yeh, if you don't mind. I think it's useful to know exactly why a change was made and what it fixes when later digging through the git history (e.g. commit 515c7af85ed9 is a great example of that). Thanks James