All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: <driverdev-devel@linuxdriverproject.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	H Hartley Sweeten <hartleys@visionengravers.com>,
	<linux-kernel@vger.kernel.org>,
	Fred Brooks <frederick.brooks@microchip.com>
Subject: Re: [PATCH 2/2 v3] staging: comedi: ni_daq_700: add AI range and input mode switching
Date: Fri, 20 Jun 2014 13:05:34 +0100	[thread overview]
Message-ID: <53A4238E.7040505@mev.co.uk> (raw)
In-Reply-To: <1403265195-32693-1-git-send-email-abbotti@mev.co.uk>

On 2014-06-20 12:53, Ian Abbott wrote:
> From: Fred Brooks <frederick.brooks@microchip.com>
>
> Add support for switching the input range and the single-ended/
> differential input mode for the AI subdevice.  We needed to clear the
> FIFO of data before the conversion to handle card mode switching
> glitches.
>
> [ Minor whitespace fixes and driver comment reformatting.  - Ian ]
>
> Signed-off-by: Fred Brooks <frederick.brooks@microchip.com>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> v2: Set authorship to Fred Brooks and updated patch description as
> suggested by Dan Carpenter.
> v3: Rebased to fix merge conflict with "staging: comedi: ni_daq_700: add
> mux settling delay" patch.  The channel number ('chan') doesn't need
> ANDing with 0xf as it will be less than 16.

I forgot to add:

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

from his reply to the v2 patch.

I'll strip out the the module version information in a subsequent patch. 
  I don't think the minor code formatting niggles matter enough to worry 
about.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

      reply	other threads:[~2014-06-20 12:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 11:15 [PATCH 0/2] staging: comedi: ni_daq_700: AI additions Ian Abbott
2014-05-29 11:15 ` [PATCH 1/2] staging: comedi: ni_daq_700: update driver comment Ian Abbott
2014-05-29 16:49   ` Hartley Sweeten
2014-05-29 11:15 ` [PATCH 2/2] staging: comedi: ni_daq_700: add AI range and input mode switching Ian Abbott
2014-05-29 11:51   ` Dan Carpenter
2014-05-29 12:13     ` Ian Abbott
2014-05-29 12:29   ` [PATCH 2/2 v2] " Ian Abbott
2014-05-29 16:47     ` Hartley Sweeten
2014-06-18 21:36       ` Greg Kroah-Hartman
2014-06-18 21:38     ` Greg Kroah-Hartman
2014-06-20 11:53       ` [PATCH 2/2 v3] " Ian Abbott
2014-06-20 12:05         ` Ian Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A4238E.7040505@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=frederick.brooks@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.